feat(core): parallel evaluate #474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should close #259 |
maartenbreddels
force-pushed
the
feat_parallel_evaluate
branch
5 times, most recently
from
06d0b76 to
38e9a39
Compare
maartenbreddels
force-pushed
the
feat_parallel_evaluate
branch
from
38e9a39 to
cd6b0c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Evaluate has become quite a beast, but there need to be 2 modes, parallel (default for users), and non-parallel (interally mostly, but also if someone else already does the multithreading).
For vaex internally, if it's in a task (say map reduce), it can call
df.dtype(..), which may calldf.evaluate, which will start another task, which is not supported.These are the two reasons why evaluate has a parallel and non-parallel mode.