Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix state transfer after rewriting virtual columns #592

Merged
merged 4 commits into from
Apr 15, 2020
Merged

Fix state transfer after rewriting virtual columns #592

merged 4 commits into from
Apr 15, 2020

Conversation

JovanVeljanoski
Copy link
Member

@JovanVeljanoski JovanVeljanoski commented Feb 14, 2020 •
edited by maartenbreddels
Loading

This PR handles the issue report in #591

  • Write test that exposes the issue
  • Implement solution
  • review and test

@maartenbreddels
Copy link
Member

Note that this has nothing to do with fillna, this also exposes the bug:

    df_train['new_x'] = df_train.x + 1
    df_train['new_x'] = df_train.x + 1

@maartenbreddels maartenbreddels force-pushed the fix_state_virtual_rename branch from c493640 to 035ef3b Compare April 15, 2020 09:56
@maartenbreddels maartenbreddels merged commit 59b53fa into master Apr 15, 2020
@maartenbreddels maartenbreddels mentioned this pull request Apr 15, 2020
Closed
@maartenbreddels maartenbreddels deleted the fix_state_virtual_rename branch May 11, 2020 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@maartenbreddels maartenbreddels

Labels
bug priority: medium
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JovanVeljanoski @maartenbreddels