-
Notifications
You must be signed in to change notification settings - Fork 4
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
test: add unit tests for builder bad practice
- Loading branch information
Showing
4 changed files
with
80 additions
and
33 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
import axios, { AxiosRequestConfig, AxiosResponse } from 'axios'; | ||
|
||
import { PostData, QueryParam, ResponseData } from './interface'; | ||
import { makePostRequest } from './request'; | ||
|
||
describe('Builder bad practice', () => { | ||
const queryParams: QueryParam = { | ||
status: 'active', | ||
role: 'user', | ||
}; | ||
|
||
const config: AxiosRequestConfig = { | ||
headers: { | ||
'Authorization': 'Bearer your-access-token', | ||
'Content-Type': 'application/json', | ||
}, | ||
params: queryParams, | ||
}; | ||
|
||
it('should send request with axios', async () => { | ||
const data: PostData = { | ||
title: 'mock title', | ||
body: 'mock description', | ||
}; | ||
|
||
const response: ResponseData = { | ||
...data, | ||
id: 1 | ||
} | ||
|
||
jest.spyOn(axios, 'post').mockReturnValue({ data: response } as unknown as Promise<AxiosResponse>) | ||
const result = await makePostRequest(data); | ||
expect(result).toEqual(response); | ||
expect(axios.post).toHaveBeenCalledTimes(1); | ||
expect(axios.post).toHaveBeenCalledWith('https://jsonplaceholder.typicode.com/posts', data, config); | ||
}) | ||
}) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,35 +1,9 @@ | ||
import axios, { AxiosRequestConfig } from 'axios'; | ||
import { PostData, ResponseData } from './interface'; | ||
import { PostData} from './interface'; | ||
import { makePostRequest } from './request'; | ||
|
||
async function makePostRequest() { | ||
const data: PostData = { | ||
title: 'test title', | ||
body: 'title description', | ||
}; | ||
const data: PostData = { | ||
title: 'test title', | ||
body: 'title description', | ||
}; | ||
|
||
const queryParams = { | ||
status: 'active', | ||
role: 'user', | ||
}; | ||
|
||
const config: AxiosRequestConfig = { | ||
headers: { | ||
'Authorization': 'Bearer your-access-token', | ||
'Content-Type': 'application/json', | ||
}, | ||
params: queryParams, | ||
}; | ||
|
||
try { | ||
const response = await axios.post<ResponseData>( | ||
'https://jsonplaceholder.typicode.com/posts', // Replace with your API endpoint | ||
data, | ||
config | ||
); | ||
console.log('Response Data:', response.data); | ||
} catch (error) { | ||
console.error('Error:', error); | ||
} | ||
} | ||
|
||
makePostRequest(); | ||
makePostRequest(data); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
import axios, { AxiosRequestConfig } from "axios"; | ||
|
||
import { PostData, QueryParam, ResponseData } from "./interface"; | ||
|
||
export async function makePostRequest(data: PostData) { | ||
const queryParams: QueryParam = { | ||
status: 'active', | ||
role: 'user', | ||
}; | ||
|
||
const config: AxiosRequestConfig = { | ||
headers: { | ||
'Authorization': 'Bearer your-access-token', | ||
'Content-Type': 'application/json', | ||
}, | ||
params: queryParams, | ||
}; | ||
|
||
try { | ||
const response = await axios.post<ResponseData>( | ||
'https://jsonplaceholder.typicode.com/posts', | ||
data, | ||
config | ||
); | ||
console.log('Response Data:', response.data); | ||
return response.data | ||
} catch (error) { | ||
console.error('Error:', error); | ||
} | ||
} |