-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add draft pru support #7
base: master
Are you sure you want to change the base?
Conversation
Pull Request Test Coverage Report for Build 86
💛 - Coveralls |
2 similar comments
Pull Request Test Coverage Report for Build 86
💛 - Coveralls |
Pull Request Test Coverage Report for Build 86
💛 - Coveralls |
Need to add compilation support. The Makefile is in bone101. |
src/pru.js
Outdated
} | ||
pruEnable(pruno, false); //disable PRU before loading firmware if not already disabled | ||
var path = fw_path + pruno + ' -fw'; | ||
shell.cp(filepath, path); //used because fs.copyFile() not supported, fast enough |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be a symlink? Does this work as a non-root user?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no it doesn't work as non-root user , will try to fix it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There may be a udev rule requirement or some other discussion with @RobertCNelson. Please share your ideas here and potentially on bbb.io/discuss to get other folks thoughts on the right balance between security and learning.
fs.writeFileSync(path, message + '\n'); | ||
} | ||
//getmsg | ||
var getrpMsg = function (pruno) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should be some way to get events via an EventEmitter asynchronously.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will make the necessary changes
src/pru.js
Outdated
} | ||
pruEnable(pruno, false); //disable PRU before loading firmware if not already disabled | ||
var path = fw_path + pruno + ' -fw'; | ||
shell.cp(filepath, path); //used because fs.copyFile() not supported, fast enough |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no it doesn't work as non-root user , will try to fix it
There will clearly be code coverage problems. Will the remote execution allow for tests on real hardware if I setup a tester farm? Will coveralls still suffer from the fact that the host is just issuing remote calls? Is there a way to import code coverage data from an automatically triggered job on remote boards. FYI for the test farm, I'm looking at setting up a number of Black Wireless boards to have some of the new BeagleBoard.org capes on them. If there are thoughts on using those capes for BoneScript testing, let me know. |
I am also aiming for remote-test support along with the remote execution implementation, i am not very sure about being able to import the coverage data, will look more into the details. |
e338a64
to
57722e1
Compare
f149b56
to
5f27270
Compare
compilation support for pru.js implemented using bone101 Makefile
added eventemitter based approach to receive rpmsg asynchronously
Draft PRU Firmware loading support