Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add draft pru support #7

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

add draft pru support #7

wants to merge 3 commits into from

Conversation

vaishnavachath
Copy link
Owner

Draft PRU Firmware loading support

@coveralls
Copy link

Pull Request Test Coverage Report for Build 86

  • 15 of 54 (27.78%) changed or added relevant lines in 2 files are covered.
  • 11 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.5%) to 36.925%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/pru.js 13 52 25.0%
Files with Coverage Reduction New Missed Lines %
src/my.js 11 19.82%
Totals Coverage Status
Change from base Build 83: -0.5%
Covered Lines: 353
Relevant Lines: 956

💛 - Coveralls

2 similar comments
@coveralls
Copy link

Pull Request Test Coverage Report for Build 86

  • 15 of 54 (27.78%) changed or added relevant lines in 2 files are covered.
  • 11 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.5%) to 36.925%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/pru.js 13 52 25.0%
Files with Coverage Reduction New Missed Lines %
src/my.js 11 19.82%
Totals Coverage Status
Change from base Build 83: -0.5%
Covered Lines: 353
Relevant Lines: 956

💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 86

  • 15 of 54 (27.78%) changed or added relevant lines in 2 files are covered.
  • 11 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.5%) to 36.925%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/pru.js 13 52 25.0%
Files with Coverage Reduction New Missed Lines %
src/my.js 11 19.82%
Totals Coverage Status
Change from base Build 83: -0.5%
Covered Lines: 353
Relevant Lines: 956

💛 - Coveralls

@jadonk
Copy link

jadonk commented May 30, 2018

Need to add compilation support. The Makefile is in bone101.

src/pru.js Outdated
}
pruEnable(pruno, false); //disable PRU before loading firmware if not already disabled
var path = fw_path + pruno + ' -fw';
shell.cp(filepath, path); //used because fs.copyFile() not supported, fast enough
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be a symlink? Does this work as a non-root user?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no it doesn't work as non-root user , will try to fix it

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There may be a udev rule requirement or some other discussion with @RobertCNelson. Please share your ideas here and potentially on bbb.io/discuss to get other folks thoughts on the right balance between security and learning.

fs.writeFileSync(path, message + '\n');
}
//getmsg
var getrpMsg = function (pruno) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be some way to get events via an EventEmitter asynchronously.

Copy link
Owner Author

@vaishnavachath vaishnavachath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will make the necessary changes

src/pru.js Outdated
}
pruEnable(pruno, false); //disable PRU before loading firmware if not already disabled
var path = fw_path + pruno + ' -fw';
shell.cp(filepath, path); //used because fs.copyFile() not supported, fast enough
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no it doesn't work as non-root user , will try to fix it

@jadonk
Copy link

jadonk commented May 30, 2018

There will clearly be code coverage problems. Will the remote execution allow for tests on real hardware if I setup a tester farm? Will coveralls still suffer from the fact that the host is just issuing remote calls? Is there a way to import code coverage data from an automatically triggered job on remote boards.

FYI for the test farm, I'm looking at setting up a number of Black Wireless boards to have some of the new BeagleBoard.org capes on them. If there are thoughts on using those capes for BoneScript testing, let me know.

@vaishnavachath
Copy link
Owner Author

I am also aiming for remote-test support along with the remote execution implementation, i am not very sure about being able to import the coverage data, will look more into the details.

@vaishnavachath vaishnavachath force-pushed the master branch 3 times, most recently from e338a64 to 57722e1 Compare June 18, 2018 00:59
@vaishnavachath vaishnavachath force-pushed the master branch 14 times, most recently from f149b56 to 5f27270 Compare July 2, 2018 08:46
compilation support for pru.js implemented using bone101 Makefile
added eventemitter based approach to receive rpmsg asynchronously
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants