-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support language tool language auto detection #103
Comments
I'd like to take the opportunity to say thank you for this project, it's great! I'd like also to share that I have forked vscode-ltex into coc-ltex, to get mostly all features in Vim or NeoVim. It's a minimal fork to reduce maintenance when syncing to upstream, which I plan doing from time to time. |
Thanks for the feature request. I did look at this before, but the fact that variants couldn't be detected, which resulted in having no spelling errors, drove me away. I'll add to the docs that it's not recommended to use this. Regarding coc-ltex, is it possible to use some |
Yeah, that's not great indeed, although I like having basic auto detection at hand, even though missing variant specific.
I'm not sure. I believe it should, as you can see, I'm just trying to apply the strictly needed changes for most of what I could infer of features to work on coc.nvim's side. I can say it's working pretty well, even for code comments, just working out of the box: I am in fact trying to manage some kind of branching in my fork, I'm leaving the develop branch there intact, while working on the default coc branch solely, and I'm applying some kind of versioning that embedded both the base vscode extension version, and the coc variant, hence 11.0.0-0.1.coc (based on vscode-ltex 11.0.0, with 0.1 coc changes on top). |
This is my first coc.nvim extension, and it's a fork 99.999999% of the work is yours. I'm not into developing it that much as I'm short of time, so, my stance with it at the moment is just to keep it up with minimal changes as far as it works, but I can't atm go much further into providing custom tests, etc. |
" |
Feature released in 14.0.0. Regarding coc.nvim, vscode-ltex 12.0.0 now supports VS Code as well as coc.nvim. I had looked at the diff and it didn't seem large to me, more akin to a different compilation target. The advantages are that vscode-ltex's CI automatically builds the coc.nvim version as well (i.e., incompatibilities are spotted earlier) and the coc.nvim version benefits from earlier updates, feature improvements as well as security/bug fixes (e.g., there was a |
This is really great. I'm a bit unsure how to proceed now, it seems that means one could just (cc @chemzqm / @fannheyward for advice) |
Ah, vscode-ltex isn't on npmjs.com, so I can manage owners for the current coc-ltex package, but I didn't find an user with your GitHub username there. |
coc.nvim supports install extensions from Github like this: I've tried this but: This means we can't use Plug 'valentjn/vscode-ltex', {'branch': 'develop', 'do': 'python3 tools/patchForTarget.py --target coc.nvim && npm install && npm run coc.nvim:prepublish'} |
TypeScript and npm don't support conditional building, that's why the patching pre-processing step is necessary. As only one target can be built at any time, the best solution is probably having a separate npm module as before. This way, the workflow doesn't change for existing users, and users don't have to worry about the patching step, since the CI would take care of this. I wouldn't use |
@valentjn I've added you as owner. |
@oblitum Thank you. Just published vscode-ltex/coc-ltex 12.1.0 (*) via a new GitHub Actions job, and LTEX seems to work for me after installing with (*) As I like to view coc.nvim as just another target like VS Code, vscode-ltex and coc-ltex will always have the same latest version. |
@valentjn really nice, just upgraded, working without issues. Gonna drop my repositories now. |
@oblitum It wouldn't have been possible without your input. Thanks again. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Please open new issues for any bugs (or feature requests) to help keep things concise, either here for server issues or over at valentjn/vscode-ltex for client issues. |
Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Using actual real-world examples that explain why you and many other users would benefit from the feature increases the request's chances of being implemented.
LanguageTool have language auto detection:
It would be great if ltex-ls provided a means to use that instead of only supporting hardcoded language.
Describe the solution you'd like
A clear and concise description of what you want to happen.
I wish some setting, no design in specific.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
None, currently I'm just configuring it manually.
Additional context
Add any other context or screenshots about the feature request here.
sylvainhalle/textidote#151
The text was updated successfully, but these errors were encountered: