Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable LTex populating the autocomplete / intellisense list #443

Closed
noelfarrugia opened this issue Oct 28, 2021 · 6 comments
Closed

Disable LTex populating the autocomplete / intellisense list #443

noelfarrugia opened this issue Oct 28, 2021 · 6 comments
Assignees
Labels
1-feature-request ✨ Issue type: Request for a desirable, nice-to-have feature 3-fixed Issue resolution: Issue has been fixed on the develop branch
Milestone

Comments

@noelfarrugia
Copy link

Is your feature request related to a problem? Please describe.
Whenever I am typing a LaTeX document, the LTeX extension suggests words from the dictionary. This is extremely annoying to have the completion window pop-up when typing. I tried looking for an option to disable this, but had no luck.

Describe the solution you'd like
Have a way of disabling the LTeX extension from populating the suggestions list.

Describe alternatives you've considered
Tried to increase the delay using the editor.quickSuggestionsDelay setting, but that made the snippets take longer to show up as well, which is far from ideal.

Additional context
Figure of the annoying suggestions that I cannot turn off
image

@noelfarrugia noelfarrugia added the 1-feature-request ✨ Issue type: Request for a desirable, nice-to-have feature label Oct 28, 2021
@valentjn
Copy link
Owner

valentjn commented Oct 28, 2021

You need to set "editor.quickSuggestions": false, or "editor.quickSuggestions": {"other": false, [...]}. Then, you can use Ctrl+Space to trigger the suggestions.

I didn't realize that VS Code has this on by default, because on all my machines, it's disabled. I'm not sure if there's a way of disabling this just for LTEX.

@noelfarrugia
Copy link
Author

The problem with disabling quickSuggestions is that to trigger snippets you would need to press Ctrl+Space which is a bit annoying. I think disabling LTeX suggestions would be the better overall solution.

@valentjn valentjn added this to LTeX Oct 28, 2021
@valentjn valentjn moved this to To Do in LTeX Oct 28, 2021
@valentjn valentjn self-assigned this Oct 28, 2021
Repository owner moved this from To Do to Done in LTeX Oct 28, 2021
valentjn added a commit that referenced this issue Oct 28, 2021
@valentjn
Copy link
Owner

Curiously, it doesn't happen in Markdown, only LATEX and other languages.

I don't see a way to handle this properly. A proper solution would be telling VS Code somehow not to show suggestions from LTEX while typing, but to show them when pressing Ctrl+Space. There's also no way for the language server to find out why the completion request was triggered. Both completions while typing (the LSP calls it “24x7 code complete”) and Ctrl+Space have the same CompletionTriggerKind value of Invoked.

As LTEX should not have this irritating behavior with VS Code's default settings, the only option is to disable LTEX completion by default. There is now a setting ltex.completionEnabled to enable them again.

@valentjn valentjn added this to the 13.0.0 milestone Oct 28, 2021
@valentjn valentjn added the 3-fixed Issue resolution: Issue has been fixed on the develop branch label Oct 28, 2021
@noelfarrugia
Copy link
Author

noelfarrugia commented Oct 29, 2021

That's excellent! Thank you so much! Do you know when v13.0.0 will be released?

@valentjn
Copy link
Owner

I can't announce any date as they greatly depend on my availability and my spare time. But you can try it out in the nightly pre-release, see the docs for more info.

@valentjn
Copy link
Owner

valentjn commented Nov 2, 2021

Fix released in 13.0.0.

me-johnomar added a commit to me-johnomar/ltex-ls that referenced this issue Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1-feature-request ✨ Issue type: Request for a desirable, nice-to-have feature 3-fixed Issue resolution: Issue has been fixed on the develop branch
Projects
Archived in project
Development

No branches or pull requests

2 participants