Merge pull request #37 from wrumsby/tough-cookie-2.3.3

Set minimum version of tough-cookie to 2.3.3
valeriangalliat · Jul 7, 2019 · 3373e12 · 3373e12
2 parents be1a07a + d864400
commit 3373e12
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/package.json b/package.json
@@ -26,7 +26,7 @@
   },
   "dependencies": {
     "es6-denodeify": "^0.1.1",
-    "tough-cookie": "^2.3.1"
+    "tough-cookie": "^2.3.3"
   },
   "devDependencies": {
     "@types/chai": "^4.1.4",

diff --git a/test/test.js b/test/test.js
@@ -56,8 +56,14 @@ describe('fetch-cookie', () => {
     // Compare the two clients (jars)
     assert.notEqual(cookie1, cookie2)
     assert.notStrictEqual(cookie1.key, cookie2.key)
-    assert.notProperty(cookies1, cookie2)
-    assert.notProperty(cookies2, cookie1)
+
+    Object.keys(cookies1).forEach(cookie1Key => {
+      assert.notProperty(cookie2, cookie1Key)
+    })
+
+    Object.keys(cookies2).forEach(cookie2Key => {
+      assert.notProperty(cookie1, cookie2Key)
+    })
   })
 
   // TODO: Remove this test once node-fetch v1 is not supported anymore