Fix clippy warnings #233
Merged
Fix clippy warnings #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for that. I've not forgotten about this, and will take care of reviewing it and merging it whenever I have a slot of time :) Been quite busy lately on other priorities, this is still stacked in my email inbox so I will not forget about that! |
|
I see that you are actively working with "Makers For Life" project. Feel free to contact me if I can help something. |
|
just resolved conflicts :) |
|
@valeriansaliou I've rebased and pushed new changes. Could you take the time to look at this PR? I think the clippy tool is very important because it gives us very useful clues that you don't always think of the first time. |
|
Excellent! Thanks a ton. I'm doing a PR and issue pass today for Sonic, so the timing is perfect :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added built-in attribute that deny some rust lints and all clippy rules (with some exceptions) and fixed all moments in the code.
These changes should reduce a bit memory allocation