Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rocksdb to 0.21 #316

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

anthonyroussel
Copy link
Contributor

Fixes #315

Build of sonic-server is failing on NixOS for a few weeks now, see https://hydra.nixos.org/build/239524816
This failing build has been caused by a clang 16 upgrade, because rocksdb depends on a old rust-bindgen version which is not compatible with this version of clang, see rust-lang/rust-bindgen#2312

A resolution is to upgrade rocksdb to its latest version.

Fixes valeriansaliou#315

Build of sonic-server is failing on NixOS
for a few weeks now, see https://hydra.nixos.org/build/239524816

This failing build has been caused by a clang 16 upgrade,
because rocksdb depends on a old rust-bindgen version which
is not compatible with this version of clang.

See rust-lang/rust-bindgen#2312

A resolution is to upgrade rocksdb to its latest version.
@anthonyroussel anthonyroussel marked this pull request as ready for review November 26, 2023 13:59
anthonyroussel added a commit to anthonyroussel/nixpkgs that referenced this pull request Nov 27, 2023
github-actions bot pushed a commit to NixOS/nixpkgs that referenced this pull request Nov 28, 2023
@valeriansaliou valeriansaliou merged commit cc116b4 into valeriansaliou:master Dec 8, 2023
@anthonyroussel anthonyroussel deleted the bump-rocksdb branch December 8, 2023 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

upgrade rocksdb dependency to use newer bindgen
2 participants