Update all strings to be stored in constants #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, thanks. Did you manage to test it on the hardware? |
|
Hi @valerionew, sorry for the late reply - I was offline last week. I have tested this on hardware and it seems to be working great 👍 |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates all string (
char*) variables and arguments to use explicit constants (const char*). This is faster and more efficient and it avoids compiler warnings due to implicit conversions to/from constants (fixes #15).In some cases, a variable was initialized and then conditionally modified. I updated these cases to check the condition at the time of assignment using a ternary expression so that unmodifiable constants can be used.