Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid setInterval keeping node process alive #84

Merged
merged 1 commit into from
Jan 24, 2020

Conversation

runeh
Copy link
Contributor

@runeh runeh commented Jan 24, 2020

No description provided.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 82.123% when pulling d4b183b on runeh:patch-1 into a53f150 on valery-barysok:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 82.123% when pulling d4b183b on runeh:patch-1 into a53f150 on valery-barysok:master.

@SimenB
Copy link

SimenB commented Jan 24, 2020

This fixes #27 without the user having to do anything. So in user code, one could do

const fileStoreOptions = {};
const store = new SessionFileStore(fileStoreOptions);

if (fileStoreOptions.reapIntervalObject) {
  fileStoreOptions.reapIntervalObject.unref();
}

I do think it should be the default behaviour, though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants