Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New/zenoh c #5

Open
wants to merge 6 commits into
base: new/zenoh-c
Choose a base branch
from
Open

New/zenoh c #5

wants to merge 6 commits into from

Conversation

oteffahi
Copy link

@oteffahi oteffahi commented Apr 4, 2024

  • Add default version Reverted due to CCI linting rules
  • Add system libraries for static build on Mac and Windows (verified locally on Mac, haven't tested on Windows)
  • Expose Zenoh-C's build options related to Zenoh features
  • Build static lib by default (CCI rule)
  • Filter supported OS/arch combination (Zenoh Team requested to limit supported targets to the ones in upstream releases)

@valgur
Copy link
Owner

valgur commented Apr 16, 2024

@oteffahi Oh. I'm sorry I missed this and the other PR by you entirely. Feel free to @ me and/or mention it under my PR the next time.

Thanks a lot for the fixes and suggestions. I incorporated them into my PR. I extended the platforms check to allow any apple OS-s and FreeBSD as well, since that's the usual practice on CCI. Does that sound ok to you?

Here's the commit: conan-io@149f833

valgur added a commit that referenced this pull request Apr 16, 2024
valgur added a commit that referenced this pull request Apr 16, 2024
@oteffahi
Copy link
Author

@valgur thank you for your comment.
Since we do not compile nor test for these operating systems in our CI, we think that it would be best to filter them out in the recipe. This is to avoid any potential issues that users may encounter, as we technically do not support those targets and therefore cannot offer much assistance. However if it is a requirement to support them on CCI then we don't really have a choice 😅

valgur added a commit that referenced this pull request Nov 12, 2024
valgur added a commit that referenced this pull request Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants