Add extraValueFiles to operator-install chart

[mhjacks]

No description provided.

[mbaldessari]

I think you also want:

diff --git a/clustergroup/values.schema.json b/clustergroup/values.schema.json
index e64a812..b1359a3 100644
--- a/clustergroup/values.schema.json
+++ b/clustergroup/values.schema.json
@@ -83,6 +83,10 @@
             }
           }
         },
+        "extraValueFiles": {
+          "type": "array",
+          "description": "List of extra values files that will be passed to ArgoCD."
+        },
         "gitops": {
           "type": "object",
           "additionalProperties": false,

Or something along those lines anyways

[mhjacks]

Do we need to talk about whether those extraValueFiles are "main" or "global"? It seems like they should be "global" since I think we intend them to also apply to subsequent applications?

[mbaldessari]

Yeah so I never really liked that main vs global distinction. In theory as far as I understood things 'main' is for things passed at 'make install' time and global is everything else. I think the distinction is non obvious so I would not hate the idea of just moving towards global

[mhjacks]

I've updated the PR:

We're using .Values.global.extraValueFiles now per discussion in slack. I've added logic to the helper template in ACM, but the tests are failing - I wanted some advice on how to fix that since it is unlike the other elements added in the ACM helper. Currently, the test is failing this way:

Testing acm chart (industrial-edge-hub) with opts [-f values-global.yaml --set global.repoURL=https://github.com/pattern-clone/mypattern --set main.git.repoURL=https://github.com/pattern-clone/mypattern --set main.git.revision=main --set global.pattern=mypattern --set global.namespace=pattern-namespace --set global.hubClusterDomain=apps.hub.example.com --set global.localClusterDomain=apps.region.example.com --set global.clusterDomain=region.example.com --set clusterGroup.imperative.jobs[0].name=test --set clusterGroup.imperative.jobs[0].playbook=ansible/test.yml -f common/examples/industrial-edge-hub.yaml]
Error: template: acm/templates/policies/application-policies.yaml:46:26: executing "acm/templates/policies/application-policies.yaml" at <include "acm.app.policies.valuefiles" .>: error calling include: template: acm/templates/_helpers.tpl:13:8: executing "acm.app.policies.valuefiles" at <$.Values.global.extraValueFiles>: nil pointer evaluating interface {}.global

Is the right thing here stubbing out .Values.global.extraValueFiles or something else?