Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Proxy with basic authentication #65

Closed
TylerGillson opened this issue Dec 19, 2023 · 0 comments
Closed

🌱 Proxy with basic authentication #65

TylerGillson opened this issue Dec 19, 2023 · 0 comments
Labels
enhancement Enhancement to an existing feature

Comments

@TylerGillson
Copy link
Member

TylerGillson commented Dec 19, 2023 •
edited
Loading

Go automatically parses basic auth credentials from HTTP_PROXY and http.DefaultClient configures http.ProxyFromEnvironment by default. So we just need to ensure we're registering any/all custom CA certs with their HTTP transports.

What HTTP clients are we talking about?

Related:
This was referenced Dec 19, 2023
Closed
Closed
@TylerGillson TylerGillson changed the title Feature Request: proxy w/ basic authentication ✨ Proxy with basic authentication Jun 11, 2024
@TylerGillson TylerGillson mentioned this issue Jun 11, 2024
Closed
@TylerGillson TylerGillson added the enhancement Enhancement to an existing feature label Jun 11, 2024
@TylerGillson TylerGillson changed the title ✨ Proxy with basic authentication 🌱 Proxy with basic authentication Jun 11, 2024
@TylerGillson TylerGillson mentioned this issue Jul 18, 2024
Merged
TylerGillson added a commit that referenced this issue Jul 19, 2024
@TylerGillson
feat: public OCI client with proxy from env support (#216)
a0ab6d6 
## Issue
Addresses #65

## Description
- add public OCI client (that handles basic auth and proxy from env in
HTTP transport)
- fail validation results if they specify invalid public key secrets
- add kv pairs from auth secrets to the environment (for ECR auth
keychain)
- add support for InsecureSkipTLSVerify

Required by:
- validator-labs/validator#333

---------

Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Enhancement to an existing feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@TylerGillson