fix: omit conditions for uninstalled plugins

validator-labs · Aug 31, 2023 · c9f430d · c9f430d
1 parent 131e5d9
commit c9f430d
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/internal/controller/valid8orconfig_controller.go b/internal/controller/valid8orconfig_controller.go
@@ -166,13 +166,12 @@ func (r *Valid8orConfigReconciler) redeployIfNeeded(ctx context.Context, vc *v1a
 	}
 
 	// delete any plugins that have been removed
-	for i, c := range vc.Status.Conditions {
+	for _, c := range vc.Status.Conditions {
 		_, ok := specPlugins[c.PluginName]
 		if !ok && c.Type == v1alpha1.HelmChartDeployedCondition && c.Status == corev1.ConditionTrue {
 			r.Log.V(0).Info("Deleting plugin Helm chart", "namespace", vc.Namespace, "name", c.PluginName)
 			r.deletePlugin(vc, c.PluginName)
 			delete(vc.Annotations, getPluginHashKey(c.PluginName))
-			conditions[i] = getHelmChartCondition(c.PluginName, false)
 		}
 	}