Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: omit secret data from ValidatorConfig #125

Merged
merged 4 commits into from
Nov 17, 2023
Merged

Conversation

TylerGillson
Copy link
Member

@TylerGillson TylerGillson commented Nov 17, 2023

The top-level validator chart cannot include sensitive data for plugin credentials in the ValidatorConfig. Therefore we need to pre-create the necessary secrets in the parent chart.

Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Copy link

codecov bot commented Nov 17, 2023

Codecov Report

Merging #125 (00fd4bb) into main (cc07547) will increase coverage by 0.37%.
Report is 3 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #125      +/-   ##
==========================================
+ Coverage   52.60%   52.97%   +0.37%     
==========================================
  Files           9        9              
  Lines         806      806              
==========================================
+ Hits          424      427       +3     
+ Misses        356      354       -2     
+ Partials       26       25       -1     

see 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0331832...00fd4bb. Read the comment docs.

Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
@TylerGillson TylerGillson merged commit e96d4fe into main Nov 17, 2023
7 checks passed
@TylerGillson TylerGillson deleted the fix-vc-security-flaw branch November 17, 2023 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant