Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement client to send FinalizeCleanup requests to spectro-cleanup #155

Merged
merged 2 commits into from
Dec 18, 2023

Conversation

ahmad-ibra
Copy link
Contributor

@ahmad-ibra ahmad-ibra commented Dec 14, 2023

Implements a client for invoking the FinalizeCleanup endpoint of spectro-cleanup:
https://buf.build/spectrocloud/spectro-cleanup/docs/main:cleanup.v1

Copy link

codecov bot commented Dec 14, 2023

Codecov Report

Merging #155 (c7255a1) into main (1e340c9) will increase coverage by 1.20%.
The diff coverage is 88.23%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #155      +/-   ##
==========================================
+ Coverage   55.49%   56.69%   +1.20%     
==========================================
  Files           9        9              
  Lines         856      889      +33     
==========================================
+ Hits          475      504      +29     
- Misses        354      357       +3     
- Partials       27       28       +1     
Files Coverage Δ
internal/controller/validatorconfig_controller.go 77.13% <88.23%> (+1.57%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e340c9...c7255a1. Read the comment docs.

@ahmad-ibra ahmad-ibra force-pushed the feat/send-finalize-cleanup branch 6 times, most recently from 2c2e0f0 to ea3f6d5 Compare December 16, 2023 01:18
@ahmad-ibra ahmad-ibra marked this pull request as ready for review December 18, 2023 17:44
@ahmad-ibra ahmad-ibra requested a review from a team December 18, 2023 17:44
@ahmad-ibra ahmad-ibra marked this pull request as draft December 18, 2023 17:49
@ahmad-ibra ahmad-ibra force-pushed the feat/send-finalize-cleanup branch 2 times, most recently from b1816c0 to b9f407b Compare December 18, 2023 19:08
@ahmad-ibra ahmad-ibra marked this pull request as ready for review December 18, 2023 19:10
@ahmad-ibra ahmad-ibra marked this pull request as draft December 18, 2023 19:19
@ahmad-ibra ahmad-ibra force-pushed the feat/send-finalize-cleanup branch 4 times, most recently from 03a2dce to 50d84b9 Compare December 18, 2023 19:56
@ahmad-ibra ahmad-ibra marked this pull request as ready for review December 18, 2023 20:00
Copy link
Member

@TylerGillson TylerGillson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Low priority, but it would be nice if the CLEANUP_GRPC_SERVER_X vars were exported from the spectro cleanup repo.

@ahmad-ibra ahmad-ibra merged commit 2ae0348 into main Dec 18, 2023
10 of 11 checks passed
@ahmad-ibra ahmad-ibra deleted the feat/send-finalize-cleanup branch December 18, 2023 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants