-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement client to send FinalizeCleanup requests to spectro-cleanup #155
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #155 +/- ##
==========================================
+ Coverage 55.49% 56.69% +1.20%
==========================================
Files 9 9
Lines 856 889 +33
==========================================
+ Hits 475 504 +29
- Misses 354 357 +3
- Partials 27 28 +1
Continue to review full report in Codecov by Sentry.
|
2c2e0f0
to
ea3f6d5
Compare
ea3f6d5
to
ff6acc9
Compare
b1816c0
to
b9f407b
Compare
03a2dce
to
50d84b9
Compare
50d84b9
to
3ccd439
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Low priority, but it would be nice if the CLEANUP_GRPC_SERVER_X
vars were exported from the spectro cleanup repo.
3ccd439
to
c7255a1
Compare
Implements a client for invoking the FinalizeCleanup endpoint of spectro-cleanup:
https://buf.build/spectrocloud/spectro-cleanup/docs/main:cleanup.v1