Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: write Helm CA cert to disk #169

Merged
merged 2 commits into from
Dec 27, 2023
Merged

fix: write Helm CA cert to disk #169

merged 2 commits into from
Dec 27, 2023

Conversation

TylerGillson
Copy link
Member

No description provided.

Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
@TylerGillson TylerGillson requested a review from a team December 27, 2023 17:24
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Copy link

codecov bot commented Dec 27, 2023

Codecov Report

Merging #169 (1e209e4) into main (7792867) will decrease coverage by 0.27%.
The diff coverage is 37.50%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #169      +/-   ##
==========================================
- Coverage   56.69%   56.42%   -0.27%     
==========================================
  Files           9        9              
  Lines         889      895       +6     
==========================================
+ Hits          504      505       +1     
- Misses        357      361       +4     
- Partials       28       29       +1     
Files Coverage Δ
internal/controller/validatorconfig_controller.go 75.75% <37.50%> (-1.38%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7792867...1e209e4. Read the comment docs.

@TylerGillson TylerGillson merged commit 51c7e6d into main Dec 27, 2023
9 of 11 checks passed
@TylerGillson TylerGillson deleted the fix/helm-ca-cert branch December 27, 2023 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant