Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update golangci-lint, add pre-commit, fix lints #304

Merged
merged 8 commits into from
Jun 27, 2024

Conversation

TylerGillson
Copy link
Member

Issue

Description

Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
@TylerGillson TylerGillson requested a review from a team as a code owner June 27, 2024 16:11
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Copy link

codecov bot commented Jun 27, 2024

Codecov Report

Attention: Patch coverage is 62.50000% with 6 lines in your changes missing coverage. Please review.

@@            Coverage Diff             @@
##             main     #304      +/-   ##
==========================================
+ Coverage   49.45%   49.66%   +0.20%     
==========================================
  Files          20       20              
  Lines        1203     1206       +3     
==========================================
+ Hits          595      599       +4     
+ Misses        542      540       -2     
- Partials       66       67       +1     
Files Coverage Δ
api/v1alpha1/validationresult_types.go 72.22% <100.00%> (ø)
internal/controller/validatorconfig_controller.go 72.09% <100.00%> (+0.99%) ⬆️
pkg/helm/secrets.go 56.66% <100.00%> (ø)
pkg/helm/helm.go 41.37% <33.33%> (-1.79%) ⬇️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e45c1c8...042193d. Read the comment docs.

Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
@TylerGillson TylerGillson merged commit caf374a into main Jun 27, 2024
7 checks passed
@TylerGillson TylerGillson deleted the ci/golangci-pre-commit branch June 27, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant