fix: ensure vsphere password is quoted #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:XS
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## main #342 +/- ##
==========================================
+ Coverage 48.58% 48.90% +0.31%
==========================================
Files 22 22
Lines 1274 1274
==========================================
+ Hits 619 623 +4
+ Misses 587 584 -3
+ Partials 68 67 -1 see 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
ahmad-ibra
force-pushed
the
fix/vsphere-values-password
branch
3 times, most recently
from
8e9e6cd
to
5b0ed88
Compare
ahmad-ibra
force-pushed
the
fix/vsphere-values-password
branch
from
5b0ed88
to
a70e799
Compare
TylerGillson
approved these changes
Jul 23, 2024
ahmad-ibra
pushed a commit
that referenced
this pull request
Jul 24, 2024
🤖 I have created a release *beep* *boop* --- ## [0.0.49](v0.0.48...v0.0.49) (2024-07-23) ### Bug Fixes * ensure vsphere password is quoted ([#342](#342)) ([3f297de](3f297de)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ensure the vsphere password is quoted to avoid any yaml to json conversion errors like the following: