feat: HTTP basic authentication secrets for network plugin #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
dosubot
bot
added
size:L
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## main #367 +/- ##
==========================================
+ Coverage 53.85% 54.21% +0.35%
==========================================
Files 21 21
Lines 1127 1127
==========================================
+ Hits 607 611 +4
+ Misses 451 448 -3
+ Partials 69 68 -1 see 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
TylerGillson
changed the title
TylerGillson
added a commit
that referenced
this pull request
Aug 5, 2024
🤖 I have created a release *beep* *boop* --- ## [0.1.1](v0.1.0...v0.1.1) (2024-08-05) ### Features * add values for maas plugin ([#364](#364)) ([7c09687](7c09687)) * HTTP basic authentication secrets for network plugin ([#367](#367)) ([128041b](128041b)) ### Dependency Updates * **deps:** update module github.com/onsi/gomega to v1.34.1 ([#344](#344)) ([5144078](5144078)) ### Refactoring * expose sinks pkg for direct rule evaluation; add ValidationResult creation & finalization helpers ([#366](#366)) ([056ee62](056ee62)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
N/A
Description
Add support for creating basic authentication secrets for the network plugin.
CA certificate secrets aren't required as they're either provided inline in the network rule spec or via a secret reference. In
validatorctlwe provide the certs inline in the spec, so we don't require a facility for creating the secrets via Helm.