Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: frequency annotation helper #422

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: frequency annotation helper #422

wants to merge 1 commit into from

Conversation

ADorigi
Copy link

@ADorigi ADorigi commented Sep 29, 2024

Issue

partially resolves #358

Description

  • A constant was added to define the annotation key validation.validator.labs/reconciliation-frequency.
  • Function FrequencyFromAnnotations which accepts annotation map and returns ctrl.Result.
  • Tests for FrequencyFromAnnotations function.

@ADorigi ADorigi requested a review from a team as a code owner September 29, 2024 20:32
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. enhancement Enhancement to an existing feature labels Sep 29, 2024
@ADorigi ADorigi mentioned this pull request Sep 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmad-ibra ahmad-ibra Awaiting requested review from ahmad-ibra ahmad-ibra is a code owner automatically assigned from validator-labs/validator

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
enhancement Enhancement to an existing feature size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🏗 Reconciliation frequency configuration via annotations
1 participant
@ADorigi