Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Support private custom image registries #81

Closed
TylerGillson opened this issue Jul 16, 2024 · 0 comments
Closed

✨ Support private custom image registries #81

TylerGillson opened this issue Jul 16, 2024 · 0 comments
Assignees
@ahmad-ibra
Labels
new-feature Net-new feature

Comments

@TylerGillson
Copy link
Member

Summary

Context

There are three image registry scenarios:

  1. Default (quay.io/validator-labs)
    • Images and charts are separate; images pulled from quay.io, charts from GitHub
  2. Hauler
    • Images and charts both served from a common OCI registry
  3. Custom (currently prompting for alternate registry host)
    • But no support for port, basic auth, CA cert, or base path. So we support public custom image registries, but not private ones. Refer to palette-cli for sample code pertaining to base path.

Requirements

Implement prompts for scenario 3. Ensure that the kind configuration is populated correctly - including base path.

Proposed top-level flow:

  • Configure Hauler for air-gapped installation?
    • If yes, scenario 2
    • If no, continue
  • Use a private image registry?
    • If yes, scenario 3
    • If no, continue
  • Using a public image registry
    • Prompt for registry host, with quay.io/validator-labs as the default
@dosubot dosubot bot added the enhancement Enhancement to an existing feature label Jul 16, 2024
@ahmad-ibra ahmad-ibra mentioned this issue Jul 17, 2024
Merged
ahmad-ibra added a commit that referenced this issue Jul 22, 2024
@ahmad-ibra
feat: add support for private custom image registries (#83)
ae91659 
## Issue
#81

## Description
This PR adds support for cutom image registries. Under the hood, the
`Registry` struct will use Hauler if its `IsAirgapped` prop is set to
true.

Tested by configuring artifacts in a harbor registry as shown below and
installing validator with `InsecureSkipTLSVerify` set to `true` (and
passing in the CA cert) and `false`

<img width="1036" alt="Screenshot 2024-07-22 at 1 40 21 PM"
src="https://github.com/user-attachments/assets/05f1646b-eeb7-46f0-86ee-c6440024b11c">
@TylerGillson TylerGillson added new-feature Net-new feature and removed enhancement Enhancement to an existing feature labels Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ahmad-ibra ahmad-ibra

Labels
new-feature Net-new feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@TylerGillson @ahmad-ibra