fix(isDataURI): fix dataURI mediaType format #1916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1916 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 102 102
Lines 2072 2072
Branches 472 472
=========================================
Hits 2072 2072
Continue to review full report at Codecov.
|
WikiRik
reviewed
Jan 28, 2022
test/validators.js
Outdated
| @@ -10151,6 +10151,7 @@ describe('Validators', () => { | |||
| ' data:text/html,%3Ch1%3EHello%2C%20World!%3C%2Fh1%3E', | |||
| 'data:,A%20brief%20note', | |||
| 'data:text/html;charset=US-ASCII,%3Ch1%3EHello!%3C%2Fh1%3E', | |||
| 'data:application/vnd.openxmlformats-officedocument.wordprocessingml.document;base64,dGVzdC5kb2N4' | |||
There was a problem hiding this comment.
Add a comma to the end of the line here and then tests should pass
profnandaa
approved these changes
Apr 22, 2022
This was referenced Jun 3, 2024
This was referenced Jun 18, 2024
This was referenced Jun 28, 2024
This was referenced Jul 10, 2024
This was referenced Jul 19, 2024
This was referenced Aug 30, 2024
This was referenced Sep 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(isDataURI): fix dataURI mediaType format
The readAsDataURL method MDN generates a dot mediaType for some file formats (.docx - application/vnd.openxmlformats-officedocument.wordprocessingml.document, . xlsx - application/vnd.openxmlformats-officedocument.spreadsheetml.sheet).
I extended the mediaType validation pattern to be compatible with readAsDataURL.
Checklist