Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added isMobilePhone valid regex for 3 countries #1925

Merged
merged 2 commits into from
Jul 19, 2022

Conversation

Mustafiz04
Copy link
Contributor

I have added valid regex for Afghanistan, Yemen and Western Sahara.
I will add more regex for missing countries mainly Caribbean and small Island.
Solved and added test for issue #1761

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

@codecov
Copy link

codecov bot commented Feb 5, 2022

Codecov Report

Merging #1925 (fba9680) into master (c193fe5) will not change coverage.
The diff coverage is n/a.

❗ Current head fba9680 differs from pull request most recent head afdbd68. Consider uploading reports for the commit afdbd68 to get more accurate results

@@            Coverage Diff            @@
##            master     #1925   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          104       102    -2     
  Lines         2120      2072   -48     
  Branches       475       472    -3     
=========================================
- Hits          2120      2072   -48     
Impacted Files Coverage Δ
src/lib/isMobilePhone.js 100.00% <ø> (ø)
src/index.js 100.00% <0.00%> (ø)
src/lib/isIP.js 100.00% <0.00%> (ø)
src/lib/alpha.js 100.00% <0.00%> (ø)
src/lib/isURL.js 100.00% <0.00%> (ø)
src/lib/isTaxID.js 100.00% <0.00%> (ø)
src/lib/isBase32.js 100.00% <0.00%> (ø)
src/lib/isLength.js 100.00% <0.00%> (ø)
src/lib/isMagnetURI.js 100.00% <0.00%> (ø)
src/lib/isCreditCard.js 100.00% <0.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c193fe5...afdbd68. Read the comment docs.

@Mustafiz04
Copy link
Contributor Author

@ezkemboi can you please review this PR ?

I apologise for being a little late for this PR because I was busy at work.
Could you please provide a place where I can learn regex because I'm having trouble developing regex for the Caribbean and tiny islands?

Copy link
Member

@rubiin rubiin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

rubiin
rubiin previously approved these changes Feb 14, 2022
@rubiin rubiin added the mc-to-land Just merge-conflict standing between the PR and landing. label Jul 18, 2022
@rubiin rubiin merged commit 89949e7 into validatorjs:master Jul 19, 2022
@rubiin
Copy link
Member

rubiin commented Jul 19, 2022

Thankyou for the contribution 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mc-to-land Just merge-conflict standing between the PR and landing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants