Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ro-Md to validate mobile phone numbers #1932

Closed
wants to merge 6 commits into from
Closed

Add ro-Md to validate mobile phone numbers #1932

wants to merge 6 commits into from

Conversation

mik7up
Copy link
Contributor

@mik7up mik7up commented Feb 14, 2022

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

@codecov
Copy link

codecov bot commented Feb 14, 2022 •
edited
Loading

Codecov Report

Merging #1932 (f7a7df4) into master (f055c11) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1932   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          102       102           
  Lines         2072      2085   +13     
  Branches       472       472           
=========================================
+ Hits          2072      2085   +13
Impacted Files Coverage Δ
src/lib/isMobilePhone.js 100.00% <ø> (ø)
src/lib/isTaxID.js 100.00% <0.00%> (ø)
src/lib/isLicensePlate.js 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f055c11...f7a7df4. Read the comment docs.

rubiin
rubiin requested changes Feb 14, 2022
View reviewed changes
Copy link
Member

@rubiin rubiin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update README (where applicable) and have tests written (where applicable)

@mihoaka
Copy link

mihoaka commented Feb 18, 2022

already done in this PR #1918

@mik7up
Copy link
Contributor Author

mik7up commented Feb 18, 2022

already done in this PR #1918

is wrong

@rubiin rubiin added the mc-to-land Just merge-conflict standing between the PR and landing. label Jul 18, 2022
@profnandaa profnandaa mentioned this pull request Jan 31, 2023
Merged
profnandaa added a commit that referenced this pull request Jan 31, 2023
@profnandaa @mik7up
feat(isMobilePhone): add ro-MD locale (#2167)
bde420b 
clean-up #1932 
---------

Co-authored-by: Mik <37216885+mik7up@users.noreply.github.com>
@profnandaa
Copy link
Member

combined in #2167

@profnandaa profnandaa closed this Jan 31, 2023
@profnandaa profnandaa mentioned this pull request Feb 2, 2023
Closed
@rntvicente rntvicente mentioned this pull request May 24, 2024
Open
@sahilpawar58 sahilpawar58 mentioned this pull request May 25, 2024
Open
@ArthurMaverick ArthurMaverick mentioned this pull request May 25, 2024
Open
@ChinmoyHembram ChinmoyHembram mentioned this pull request May 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rubiin rubiin rubiin requested changes

Assignees
No one assigned
Labels
mc-to-land Just merge-conflict standing between the PR and landing. PR/combined
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mik7up @mihoaka @profnandaa @rubiin