Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/jamaica addition #1986

Merged
merged 3 commits into from
Jul 19, 2022
Merged

Conversation

ademyan05
Copy link
Contributor

added Jamaica's locale into isMobilePhone.js

rubiin
rubiin previously approved these changes Jun 21, 2022
@codecov
Copy link

codecov bot commented Jun 24, 2022

Codecov Report

❗ No coverage uploaded for pull request base (master@7832d4a). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 7786bb3 differs from pull request most recent head 35fc280. Consider uploading reports for the commit 35fc280 to get more accurate results

@@            Coverage Diff             @@
##             master     #1986   +/-   ##
==========================================
  Coverage          ?   100.00%           
==========================================
  Files             ?       103           
  Lines             ?      2097           
  Branches          ?       473           
==========================================
  Hits              ?      2097           
  Misses            ?         0           
  Partials          ?         0           
Impacted Files Coverage Δ
src/lib/isMobilePhone.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7832d4a...35fc280. Read the comment docs.

@rubiin
Copy link
Member

rubiin commented Jul 17, 2022

@ademyan05 can you fix the conflict

@rubiin rubiin merged commit 450a2c0 into validatorjs:master Jul 19, 2022
@rubiin
Copy link
Member

rubiin commented Jul 19, 2022

Thankyou for the contribution 🎉

@rieg-ec
Copy link

rieg-ec commented Dec 16, 2022

it seems like this deleted the fix for Honduras phone numbers by mistake 😢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants