Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(isLicensePlate): add es-AR license plate validator #2103

Closed
wants to merge 1 commit into from

Conversation

alvarocastro
Copy link

@alvarocastro alvarocastro commented Nov 20, 2022

Added validation regex for Argentina license plates whose format can be AB 123 CD or ABC 123.

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

@codecov
Copy link

codecov bot commented Nov 20, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (3476598) compared to base (531dc7f).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #2103   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          104       104           
  Lines         2308      2309    +1     
  Branches       578       578           
=========================================
+ Hits          2308      2309    +1     
Impacted Files Coverage Δ
src/lib/isLicensePlate.js 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@WikiRik WikiRik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have a source on this?

@alvarocastro
Copy link
Author

alvarocastro commented Dec 13, 2022

Do you have a source on this?

I live in Argentina, couldn't find any "official" source, but here is a wikipedia article: https://en.wikipedia.org/wiki/Vehicle_registration_plates_of_Argentina

This validator supports:

  • The old format "ABC 123" (specific for Argentina) that it's still valid but not issued anymore and;
  • The new format "AB 123 CD" which is the current Argentine standard (actually is the standard for all the Mercosur countries).

@rubiin rubiin added ✅ LGTM and removed ✅ LGTM labels Jan 23, 2023
@rubiin rubiin requested a review from WikiRik January 23, 2023 07:08
Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your PR. I'll fix the merge conflict in the release.

@profnandaa profnandaa added mc-to-land Just merge-conflict standing between the PR and landing. ✅ LGTM labels Jan 29, 2023
profnandaa added a commit that referenced this pull request Jan 31, 2023
Co-authored-by: Alvaro Castro <moltar89@gmail.com>

@profnandaa: clean up #2103
@profnandaa
Copy link
Member

combined in #2164

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎉 first-pr ✅ LGTM mc-to-land Just merge-conflict standing between the PR and landing. PR/combined
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants