-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(isLicensePlate): add es-AR license plate validator #2103
Conversation
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #2103 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 104 104
Lines 2308 2309 +1
Branches 578 578
=========================================
+ Hits 2308 2309 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have a source on this?
I live in Argentina, couldn't find any "official" source, but here is a wikipedia article: https://en.wikipedia.org/wiki/Vehicle_registration_plates_of_Argentina This validator supports:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for your PR. I'll fix the merge conflict in the release.
Co-authored-by: Alvaro Castro <moltar89@gmail.com> @profnandaa: clean up #2103
combined in #2164 |
Added validation regex for Argentina license plates whose format can be
AB 123 CD
orABC 123
.Checklist