-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(isMobilePhone): Add regex for Somalia so-SO #2175
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM, we're just about to make our next release and the preps are done. Unfortunately this will miss the train but should be on the next one.
Please fix the merge conflicts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Please check @rubiin @profnandaa @tux-tn
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #2175 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 105 105
Lines 2324 2324
Branches 586 586
=========================================
Hits 2324 2324
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Added regex validation for Somalia (so-SO) mobile phone numbers, country codes referenced from these documents:
Checklist