Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(isLocale): add support for validation of more valid language tags #2189

Merged
merged 1 commit into from
Mar 27, 2023

Conversation

kwahome
Copy link
Contributor

@kwahome kwahome commented Feb 21, 2023

feat(isLocale): Add support for validation of more valid language tags

Implement RFC 5646 compliant regex to validate language tags and locales.

Fix for #2100

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)
  • References provided in PR (where applicable)

@codecov
Copy link

codecov bot commented Feb 21, 2023

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (8147ed4) compared to base (43803c0).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #2189   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          106       106           
  Lines         2348      2359   +11     
  Branches       593       592    -1     
=========================================
+ Hits          2348      2359   +11     
Impacted Files Coverage Δ
src/lib/isLocale.js 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kwahome kwahome marked this pull request as ready for review February 21, 2023 16:34
Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contrib @kwahome ! 🎉

@profnandaa profnandaa changed the title Implement RFC 5646 compliant regex to validate language tags and locales new validator: isLocale, add support for validation of more valid language tags Mar 7, 2023
@profnandaa profnandaa merged commit fc49ad7 into validatorjs:master Mar 27, 2023
@profnandaa profnandaa changed the title new validator: isLocale, add support for validation of more valid language tags fix(isLocale): add support for validation of more valid language tags Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants