Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding TaxId validation for Argentina #2224

Merged
merged 1 commit into from
Aug 18, 2023

Conversation

estefrare
Copy link
Contributor

@estefrare estefrare commented May 14, 2023

Add tax id validations for Argentinian format. It includes validation for CUIT and CUIL.

It is based on:

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)
  • References provided in PR (where applicable)

@codecov
Copy link

codecov bot commented May 14, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (9ba1735) 99.95% compared to head (5dd31c4) 99.95%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2224   +/-   ##
=======================================
  Coverage   99.95%   99.95%           
=======================================
  Files         107      107           
  Lines        2405     2417   +12     
  Branches      604      606    +2     
=======================================
+ Hits         2404     2416   +12     
  Partials        1        1           
Impacted Files Coverage Δ
src/lib/isTaxID.js 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rubiin rubiin added the ✅ LGTM label Aug 3, 2023
Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution! 🎉

@profnandaa profnandaa merged commit 3541b0d into validatorjs:master Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants