feat(isMobilePhone): Added regex for Sudan ar-SD #2246
Conversation
src/lib/isMobilePhone.js
Outdated
| @@ -16,6 +16,7 @@ const phones = { | |||
| 'ar-OM': /^((\+|00)968)?(9[1-9])\d{6}$/, | |||
| 'ar-PS': /^(\+?970|0)5[6|9](\d{7})$/, | |||
| 'ar-SA': /^(!?(\+?966)|0)?5\d{8}$/, | |||
| 'ar-SD': /^(!?(\+?249)|0)?(9[0123569]|1[01258])\d{7}$/, | |||
There was a problem hiding this comment.
| 'ar-SD': /^(!?(\+?249)|0)?(9[0123569]|1[01258])\d{7}$/, | |
| 'ar-SD': /^(!?(\+?249)|0)?(9[123569])\d{7}$/, |
I do not see +249 90 XXX XXXX in the ITU document nor the other reference that Wikipedia uses, but we can add those if you have an alternative source (possibly from the Zain Sudan website). The numbers +249 1X XXX XXXX are not mobile phones so they should not be a part of this validator.
There was a problem hiding this comment.
+249 90 XXX XXXX is valid and +249 95 XXX XXXX isn't according to ITU's Sudan Numbering Plan, according to the same doc Sudani/Sudatel Sudan provides mobile services. The Wikiperdia page seems outdated, I will try to update it.
There was a problem hiding this comment.
Thanks for that new source. Do you happen to have an update to that as well? The presentation mentions problems with overlapping +249 100/11/12 and a planned solution but I'd like to know if that was implemented and what the current state is
There was a problem hiding this comment.
Unfortunately, I couldn't find any updated documents or articles concerning the overlapping issue. Either the solution wasn't publicated or not implemented yet. Cannot get in touch with either companies due to the current affairs.
There was a problem hiding this comment.
Let's keep it like this for now then, and we can see if in the future we can find more documentation on this. Just need to fix the tests and then we should be good
There was a problem hiding this comment.
I'm sorry but I don't know why the tests aren't passing. How can I fix it?
test/validators.test.js
Outdated
| invalid: [ | ||
| '12345', | ||
| '', | ||
| '+249962662622', |
There was a problem hiding this comment.
This phone number is not invalid due to the regular expression so that's why the test is failing
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #2246 +/- ##
=======================================
Coverage 99.95% 99.95%
=======================================
Files 107 107
Lines 2419 2419
Branches 608 608
=======================================
Hits 2418 2418
Partials 1 1
☔ View full report in Codecov by Sentry. |
feat(isMobilePhone): Added regex for Sudan ar-SD
Added validation for Sudanese mobile (ar-SD)
Resourses
Wikipedia
International Telecommunication Union
Checklist