Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(isVAT): fixed KZ VAT number length check #2279

Merged
merged 2 commits into from
Apr 27, 2024

Conversation

MatthieuLemoine
Copy link
Contributor

@MatthieuLemoine MatthieuLemoine commented Aug 30, 2023

According to Wikipedia and the source linked in this article, Kazakh VAT numbers are 12 digits long, not 9.

image

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)
  • References provided in PR (where applicable)

@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (b958bd7) 99.95% compared to head (6fa00af) 99.95%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2279   +/-   ##
=======================================
  Coverage   99.95%   99.95%           
=======================================
  Files         107      107           
  Lines        2454     2454           
  Branches      619      619           
=======================================
  Hits         2453     2453           
  Partials        1        1           
Files Changed Coverage Δ
src/lib/isVAT.js 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@profnandaa profnandaa merged commit 11ac6a4 into validatorjs:master Apr 27, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants