-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(isEmail): allow regexp in host_whitelist and host_blacklist #2494
feat(isEmail): allow regexp in host_whitelist and host_blacklist #2494
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good so far
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2494 +/- ##
===========================================
- Coverage 100.00% 99.96% -0.04%
===========================================
Files 110 112 +2
Lines 2510 2526 +16
Branches 633 638 +5
===========================================
+ Hits 2510 2525 +15
- Partials 0 1 +1 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Appreciate a review of this PR 🙇♂️ |
This PR enhance the host_whitelist and host_blacklist of isEmail validator to use regexp.
References: #562
Checklist