Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(isEmail): allow regexp in host_whitelist and host_blacklist #2494

Conversation

weikangchia
Copy link
Contributor

This PR enhance the host_whitelist and host_blacklist of isEmail validator to use regexp.

References: #562

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)
  • References provided in PR (where applicable)

@weikangchia
Copy link
Contributor Author

Appreciate a review of this PR 🙇‍♂️
cc: @rubiin @WikiRik

Copy link
Member

@rubiin rubiin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good so far

Copy link

codecov bot commented Nov 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.96%. Comparing base (f81d857) to head (541152c).
Report is 16 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##            master    #2494      +/-   ##
===========================================
- Coverage   100.00%   99.96%   -0.04%     
===========================================
  Files          110      112       +2     
  Lines         2510     2526      +16     
  Branches       633      638       +5     
===========================================
+ Hits          2510     2525      +15     
- Partials         0        1       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@weikangchia
Copy link
Contributor Author

Appreciate a review of this PR 🙇‍♂️
cc: @profnandaa @ezkemboi @tux-tn @chriso

@WikiRik WikiRik changed the title feat(isEmail): enhance isEmail host_whitelist and host_blacklist to use regexp feat(isEmail): allow regexp in host_whitelist and host_blacklist Nov 21, 2024
@WikiRik WikiRik merged commit 86911d8 into validatorjs:master Nov 21, 2024
11 of 12 checks passed
@weikangchia
Copy link
Contributor Author

Thanks @rubiin and @WikiRik for the review. Just curious when is the next release and will this change be part of the next release as I would like to use this feature in my project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants