Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build #1

Closed
wants to merge 3 commits into from
Closed

Fix build #1

wants to merge 3 commits into from

Conversation

Speedy37
Copy link

@Speedy37 Speedy37 commented Nov 4, 2021 •
edited
Loading

  • Windows SDK 10.0.22000
  • Missing files in vcxproj
  • Missing milliseconds_now definition
  • GitHub Action to detect this issues on push

@Speedy37 Speedy37 marked this pull request as draft November 4, 2021 18:27
@Speedy37
Copy link
Author

Speedy37 commented Nov 4, 2021

I'll add a github action + fixes to make this build outside ExplorerPatcher project

@Speedy37 Speedy37 marked this pull request as ready for review November 4, 2021 18:33
@Speedy37 Speedy37 mentioned this pull request Nov 4, 2021
Open
@Speedy37 Speedy37 changed the title Support Windows SDK 10.0.22000.0 Fix build Nov 4, 2021
@valinet
Copy link
Owner

valinet commented Nov 4, 2021

Thanks, I have manually merged in the changes because I wanted to address the milliseconds_now more proper, in that I made a separate sws_utility.h header and prefixed it with sws_ as with all functions in this project.

Huge thanks for the pointers provided, and for contributing.

@valinet valinet closed this Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Speedy37 @valinet