-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CP-12: Adds support for 'currency_conversion' config option #28
Conversation
Ждёт апрува и влива valitydev/limiter-proto#44 и valitydev/damsel#129 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
а тесты с работающей конвертацией работают?
Прежние тесты остались. Это те что были на моке ещё до добавления общего флага в env. limiter/apps/limiter/test/lim_turnover_SUITE.erl Lines 244 to 255 in 08a0277
Там простой мок функции xrate limiter/apps/limiter/test/lim_turnover_SUITE.erl Lines 747 to 748 in 08a0277
|
Другое дело что может стоит отказаться от глобального флага |
No description provided.