This repository has been archived by the owner on Oct 10, 2023. It is now read-only.
add withdrawal adjustment listener #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strug
reviewed
Sep 14, 2023
| @@ -26,7 +27,8 @@ public void handleEvents(List<MachineEvent> machineEvents) { | |||
| private void handleIfAccept(MachineEvent machineEvent) { | |||
| TimestampedChange eventPayload = parser.parse(machineEvent); | |||
| if (eventPayload.isSetChange()) { | |||
| withdrawalHandlers.stream() | |||
| List<WithdrawalHandler> filteredHandlerList = withdrawalHandlerFilterService.filterAdjustment(withdrawalHandlers); | |||
There was a problem hiding this comment.
а не проще тогда просто оставить только на одном интерфейсе и потом обратно вернуть, это просто все равно как костыль немного смотрится(
There was a problem hiding this comment.
а не проще тогда просто оставить только на одном интерфейсе и потом обратно вернуть, это просто все равно как костыль немного смотрится(
Согласен, что выглядит как костыль.
Мне кажется, потому что само решение выглядит как временный костыль.
Я поправил. Как будто, так даже красивее)
strug
approved these changes
Sep 14, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.