Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency com.github.tomakehurst:wiremock-jre8-standalone to v2.35.1 [SECURITY] - autoclosed #41

Conversation

renovate[bot]
Copy link

@renovate renovate bot commented Sep 8, 2023

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
com.github.tomakehurst:wiremock-jre8-standalone (source) 2.33.2 -> 2.35.1 age adoption passing confidence

GitHub Vulnerability Alerts

CVE-2023-41329

Impact

The proxy mode of WireMock, can be protected by the network restrictions configuration, as documented in Preventing proxying to and recording from specific target addresses. These restrictions can be configured using the domain names, and in such a case the configuration is vulnerable to the DNS rebinding attacks. A similar patch was applied in WireMock 3.0.0-beta-15 for the WireMock Webhook Extensions.

The root cause of the attack is a defect in the logic which allows for a race condition triggered by a DNS server whose address expires in between the initial validation and the outbound network request that might go to a domain that was supposed to be prohibited. Control over a DNS service is required to exploit this attack, so it has high execution complexity and limited impact.

Affected versions

  • WireMock 3,x until 3.0.3 (security patch), on default settings in environments with access to the network
  • WireMock 2.x until 2.35.1 (security patch), on default settings in environments with access to the network
  • Python WireMock until 2.6.1
  • WireMock Studio - all versions, this proprietary product was discontinued in 2022

Patches

  • WireMock 3.0.3 + the 3.0.3-1 Docker image
  • WireMock 2.35.1 + the 2.35.1-1 Docker image - backport to WireMock 2.x
  • Python WireMock 2.6.1

Workarounds

For WireMock:

  • Option 1: Configure WireMock to use IP addresses instead of the domain names in the outbound URLs subject to DNS rebinding
  • Option 2: Use external firewall rules to define the list of permitted destinations

For WireMock Studio: N/A. Switch to another distribution, there will be no fix provided. The vendor of former WireMock Studio recommends migration to WireMock Cloud

References


Release Notes

wiremock/wiremock (com.github.tomakehurst:wiremock-jre8-standalone)

v2.35.1: - Security Release

Compare Source

🔒 This is a security release that addresses the following issues

NOTE: WireMock Studio, a proprietary distribution discontinued in 2022, is also affected by those issues and also affected by CVE-2023-39967 - Overall CVSS Score 8.6 - “Controlled and full-read SSRF through URL parameter when testing a request, webhooks and proxy mode”. The fixes will not be provided. The vendor recommends migrating to WireMock Cloud which is available as SaaS and private beta for on-premises deployments

Credits: @​W0rty, @​numacanedo, @​Mahoney, @​tomakehurst, @​oleg-nenashev

v2.35.0

Compare Source

Enhancements

  • Add a negative contains matcher - thanks Damian Orzepowski
  • Expose a Java API method for removing stubs by ID - thanks Patryk Fraczek
  • Document the import API in the OpenAPI doc - thanks to user i-whammy
  • Added the ability to restrict the addresses WireMock can proxy/record to, as a security measure.

Fixes

  • Strip Maven directories from the standalone JAR as some were appearing that weren't related to dependencies actually present, confusing scanning tools - thanks to user krageon
  • Dropped back to slf4j 1.7.36 and relocate it in the standalone JAR (ensuring 2.x users won't experience conflicts).

v2.34.0

Compare Source

This will be the final 2.x.x release and also the last to support Java 8.

Fixes

  • Fixed #​1689 - incorrect HTTP version header - thanks to user Poojitha
  • Fixed #​1882 - bug preventing matching of date/time query params/headers with custom format - thanks Klaas Dellschaft
  • #​1930 - Fixed a partial path traversal vulnerability in the file source code - thanks Jonathan Leitschuh
  • Fixed #​1783 - proxyUrlPrefixToRemove ignored when using a response definition transformer - thanks to user Ross-H-Projects
  • Fixed #​1872 - create a request entity for POST, PUT etc. proxied requests when a content-length header is present, regardless of whether the size is 0.
  • Fixed #​1946 - maths helper now supports epoch dates as inputs.

Enhancements

  • Added a public, non-static getScenarios() method allowing access to all scenarios.

All dependencies brought up to date including Jetty to 9.4.48.v20220622.


Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Merging #41 (8f472b2) into master (b7f3cbc) will increase coverage by 0.07%.
Report is 19 commits behind head on master.
The diff coverage is 87.65%.

❗ Current head 8f472b2 differs from pull request most recent head 5de4021. Consider uploading reports for the commit 5de4021 to get more accurate results

@@             Coverage Diff              @@
##             master      #41      +/-   ##
============================================
+ Coverage     65.13%   65.21%   +0.07%     
- Complexity       47       51       +4     
============================================
  Files            18       17       -1     
  Lines           218      207      -11     
  Branches         11       16       +5     
============================================
- Hits            142      135       -7     
+ Misses           73       71       -2     
+ Partials          3        1       -2     
Files Coverage Δ
.../java/dev/vality/wachter/client/WachterClient.java 86.66% <100.00%> (+0.95%) ⬆️
...n/java/dev/vality/wachter/security/AccessData.java 85.71% <100.00%> (+7.93%) ⬆️
...ava/dev/vality/wachter/security/AccessService.java 100.00% <100.00%> (+32.00%) ⬆️
...dev/vality/wachter/security/RoleAccessService.java 100.00% <100.00%> (ø)
...ava/dev/vality/wachter/service/WachterService.java 95.23% <100.00%> (ø)
...dev/vality/wachter/constants/HeadersConstants.java 0.00% <0.00%> (ø)
.../vality/wachter/client/WachterResponseHandler.java 18.18% <18.18%> (ø)

... and 1 file with indirect coverage changes

@renovate renovate bot force-pushed the renovate/maven-com.github.tomakehurst-wiremock-jre8-standalone-vulnerability branch from 8f472b2 to 5de4021 Compare October 19, 2023 10:38
@renovate renovate bot changed the title Update dependency com.github.tomakehurst:wiremock-jre8-standalone to v2.35.1 [SECURITY] Update dependency com.github.tomakehurst:wiremock-jre8-standalone to v2.35.1 [SECURITY] - autoclosed Jun 27, 2024
@renovate renovate bot closed this Jun 27, 2024
@renovate renovate bot deleted the renovate/maven-com.github.tomakehurst-wiremock-jre8-standalone-vulnerability branch June 27, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants