Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebranding docs/install/ #44

Merged
merged 8 commits into from
Apr 23, 2024
Merged

Conversation

zuiderkwast
Copy link
Contributor

@zuiderkwast zuiderkwast commented Apr 23, 2024

This PR does the bulk of renaming:

  • Remove "redis" in CLI prompt "redis 127.0.0.1:6379>"
  • Change "Redis" to "Valkey" using Perl regex Redis(?! compatibility| v?[1-7]| version| < [1-7]| OSS|\.[a-z]|\w)
  • Replace filenames redis(-cli|-server|-benchmark|.conf) with valkey equivalents
  • Replace /etc/redis and /var/redis with valkey equivalent paths
  • "redis_6379" -> "valkey_6379"

Part of #18

Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
…uivalents

Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
Copy link
Member

@stockholmux stockholmux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this was mostly just a search/replace PR but there are things that won't work here.

docs/install/_index.md Show resolved Hide resolved
docs/install/install-redis/_index.md Show resolved Hide resolved
docs/install/install-redis/install-redis-on-linux.md Outdated Show resolved Hide resolved
docs/install/install-redis/install-redis-on-linux.md Outdated Show resolved Hide resolved
docs/install/install-redis/_index.md Show resolved Hide resolved
Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
@zuiderkwast
Copy link
Contributor Author

I added info about docker containers under the linux install page.

I updated the mac page to say "brew install valkey" and other commands like "brew services start valkey". I hope it works. :)

Let's improve this information later. I just want to delete wrong info for now.

Delete some irrelevant sections of text.

Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
@hwware hwware merged commit f4c80f2 into valkey-io:main Apr 23, 2024
1 check passed
@zuiderkwast zuiderkwast deleted the rebranding-docs-install branch April 24, 2024 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants