Skip to content

Commit

Permalink
hardcoding encoder option for lcsIdx
Browse files Browse the repository at this point in the history
Signed-off-by: TJ Zhang <tj.zhang@improving.com>
  • Loading branch information
TJ Zhang committed Aug 27, 2024
1 parent 4d625e5 commit 07d59b1
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions node/src/BaseClient.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6304,7 +6304,6 @@ export class BaseClient {
* @param options - (Optional) Additional parameters:
* - (Optional) `withMatchLen`: if `true`, include the length of the substring matched for the each match.
* - (Optional) `minMatchLen`: the minimum length of matches to include in the result.
* - (Optional) `decoder`: see {@link DecoderOption}.
* @returns A `Record` containing the indices of the longest common subsequences between the
* 2 strings and the lengths of the longest common subsequences. The resulting map contains two
* keys, "matches" and "len":
Expand Down Expand Up @@ -6345,12 +6344,11 @@ export class BaseClient {
options?: {
withMatchLen?: boolean;
minMatchLen?: number;
} & DecoderOption,
},
): Promise<Record<string, (number | [number, number])[][] | number>> {
// TODO: convert Record return type to Object array
return this.createWritePromise(
createLCS(key1, key2, { idx: options ?? {} }),
options,
{ decoder: Decoder.String },
);
}

Expand Down

0 comments on commit 07d59b1

Please sign in to comment.