Align main with changes needed for hybrid publish #1199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avifenesh
requested review from
barshaul,
asafpamzn,
shachlanAmazon and
shohamazon
avifenesh
force-pushed
the
version0.3.3intoMain
branch
2 times, most recently
from
b193059
to
a929c32
Compare
avifenesh
force-pushed
the
version0.3.3intoMain
branch
from
a929c32
to
032e2c2
Compare
barshaul
approved these changes
Apr 2, 2024
The first approach where to create different builds, but our usage of different packages for each platform made it impossible, and the solution was almost duplicate all code to different versions, to support the different chains of import statements types. But apparently, if the whole package compiled to common, and at the starting point common put export default ecma know how to deal with it from there. Not true for the opposite. So the simple, easy and hidden solution, that no-body mention for some reason, is apparently the best one. |
shohamazon
pushed a commit
to adanWattad/glide-for-redis
that referenced
this pull request
Apr 9, 2024
* Align main with changes needed for hybrid publish * remove unnecessary info * add relevant changes to the change log
cyip10
pushed a commit
to Bit-Quill/valkey-glide
that referenced
this pull request
Jun 24, 2024
* Align main with changes needed for hybrid publish * remove unnecessary info * add relevant changes to the change log
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it appear, altho commonjs cannot use ES modules - ES modules can use commonjs, with the limits that export default is emitted.
After trying every version of hybrid build, apparently the simplest option is the best one.
We build into commonjs, in our index.ts we are using export default, and the package can be used for all type of users.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.