Java: Add LASTSAVE command.
#1297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add `LASTSAVE` command. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * PR comments. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * PR comments. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * PR comments. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> --------- Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
…STSAVE Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Yury-Fridlyand
requested review from
aaron-congo,
jonathanl-bq,
barshaul,
acarbonetto,
shohamazon and
SanHalacogluImproving
jonathanl-bq
approved these changes
Apr 17, 2024
aaron-congo
reviewed
Apr 17, 2024
| @@ -132,4 +133,9 @@ public CompletableFuture<String[]> time() { | |||
| return commandManager.submitNewCommand( | |||
| Time, new String[0], response -> castArray(handleArrayResponse(response), String.class)); | |||
| } | |||
|
|
|||
| @Override | |||
| public CompletableFuture<Long> lastsave() { | |||
There was a problem hiding this comment.
Not sure if this should be camel-case or left all lower-case?
Suggested change
| public CompletableFuture<Long> lastsave() { | |
| public CompletableFuture<Long> lastSave() { |
There was a problem hiding this comment.
All commands are in lowercase, except two-word commands like clientId, etc
java/client/src/main/java/glide/api/models/BaseTransaction.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> Co-authored-by: Aaron <69273634+aaron-congo@users.noreply.github.com>
aaron-congo
approved these changes
Apr 17, 2024
Elen-Ghulam
approved these changes
Apr 17, 2024
aaron-congo
added a commit
to Bit-Quill/valkey-glide
that referenced
this pull request
Apr 22, 2024
* Add `LASTSAVE` command. (#222) Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> Co-authored-by: Aaron <69273634+aaron-congo@users.noreply.github.com>
cyip10
pushed a commit
to Bit-Quill/valkey-glide
that referenced
this pull request
Jun 24, 2024
* Add `LASTSAVE` command. (#222) Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> Co-authored-by: Aaron <69273634+aaron-congo@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
https://redis.io/docs/latest/commands/lastsave/
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.