Python: add SDIFF command #1437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaron-congo
commented
May 22, 2024
| @@ -501,7 +501,7 @@ pub(crate) fn expected_type_for_cmd(cmd: &Cmd) -> Option<ExpectedReturnType> { | |||
| b"HEXISTS" | b"HSETNX" | b"EXPIRE" | b"EXPIREAT" | b"PEXPIRE" | b"PEXPIREAT" | |||
| | b"SISMEMBER" | b"PERSIST" | b"SMOVE" | b"RENAMENX" => Some(ExpectedReturnType::Boolean), | |||
| b"SMISMEMBER" => Some(ExpectedReturnType::ArrayOfBools), | |||
| b"SMEMBERS" | b"SINTER" => Some(ExpectedReturnType::Set), | |||
| b"SMEMBERS" | b"SINTER" | b"SDIFF" => Some(ExpectedReturnType::Set), | |||
There was a problem hiding this comment.
RESP3 returns a set, which is what we want, but RESP2 returns an array, so I added this here to convert RESP2 responses
Yury-Fridlyand
approved these changes
May 22, 2024
GumpacG
approved these changes
May 23, 2024
aaron-congo
force-pushed
the
python/integ_acongo_sdiff
branch
from
71aa1b0
to
7170163
Compare
Elen-Ghulam
approved these changes
May 23, 2024
acarbonetto
approved these changes
May 23, 2024
cyip10
pushed a commit
to Bit-Quill/valkey-glide
that referenced
this pull request
Jun 24, 2024
Python: add SDIFF command (#295)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
https://redis.io/docs/latest/commands/sdiff/
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.