Java: Add HSTRLEN command.
#1463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…TRLEN Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
aaron-congo
reviewed
May 24, 2024
| @@ -225,7 +225,7 @@ public interface HashBaseCommands { | |||
| /** | |||
| * Returns all field names in the hash stored at <code>key</code>. | |||
| * | |||
| * @see <a href="https://valkey.io/commands/hkeys/">redis.io</a> for details | |||
| * @see <a href="https://valkey.io/commands/hkeys/">redis.io</a> for details. | |||
There was a problem hiding this comment.
don't have to change this now necessarily as I imagine this has to be updated in other spots too, but we should do it at some point
Suggested change
| * @see <a href="https://valkey.io/commands/hkeys/">redis.io</a> for details. | |
| * @see <a href="https://valkey.io/commands/hkeys/">valkey.io</a> for details. |
java/client/src/main/java/glide/api/commands/HashBaseCommands.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/models/BaseTransaction.java
Outdated
Show resolved
Hide resolved
acarbonetto
approved these changes
May 24, 2024
Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
aaron-congo
approved these changes
May 24, 2024
jonathanl-bq
approved these changes
May 24, 2024
Elen-Ghulam
approved these changes
May 24, 2024
cyip10
pushed a commit
to Bit-Quill/valkey-glide
that referenced
this pull request
Jun 24, 2024
* Java: Add `HSTRLEN` command. (#298) * Add `HSTRLEN` command. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Update for review comments Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> --------- Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> Co-authored-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
https://redis.io/docs/latest/commands/hstrlen/
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.