-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Java: add RENAME command #1481
Java: add RENAME command #1481
Conversation
public void rename(BaseClient client) { | ||
String key1 = "{key}" + UUID.randomUUID(); | ||
|
||
assertEquals("OK", client.set(key1, "foo").get()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
assertEquals("OK", client.set(key1, "foo").get()); | |
assertEquals(OK, client.set(key1, "foo").get()); |
String key1 = "{key}" + UUID.randomUUID(); | ||
|
||
assertEquals("OK", client.set(key1, "foo").get()); | ||
assertEquals("OK", client.rename(key1, key1 + "_rename").get()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
assertEquals("OK", client.rename(key1, key1 + "_rename").get()); | |
assertEquals(OK, client.rename(key1, key1 + "_rename").get()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sure to address Andrew's comments
* implement rename command in new PR * address comments * address new comments * address sharedCommandTest comments --------- Co-authored-by: Chloe Yip <chloe.yip@Chloes-MacBook-Pro.local>
Issue #, if available:
N/A
Description of changes:
https://redis.io/docs/latest/commands/rename/
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.