Java: add RENAME command #1481
Merged
Java: add RENAME command #1481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acarbonetto
reviewed
May 28, 2024
| public void rename(BaseClient client) { | ||
| String key1 = "{key}" + UUID.randomUUID(); | ||
|
|
||
| assertEquals("OK", client.set(key1, "foo").get()); |
There was a problem hiding this comment.
Suggested change
| assertEquals("OK", client.set(key1, "foo").get()); | |
| assertEquals(OK, client.set(key1, "foo").get()); |
acarbonetto
reviewed
May 28, 2024
| String key1 = "{key}" + UUID.randomUUID(); | ||
|
|
||
| assertEquals("OK", client.set(key1, "foo").get()); | ||
| assertEquals("OK", client.rename(key1, key1 + "_rename").get()); |
There was a problem hiding this comment.
Suggested change
| assertEquals("OK", client.rename(key1, key1 + "_rename").get()); | |
| assertEquals(OK, client.rename(key1, key1 + "_rename").get()); |
acarbonetto
approved these changes
May 28, 2024
jonathanl-bq
approved these changes
May 28, 2024
cyip10
added a commit
to Bit-Quill/valkey-glide
that referenced
this pull request
Jun 24, 2024
* implement rename command in new PR * address comments * address new comments * address sharedCommandTest comments --------- Co-authored-by: Chloe Yip <chloe.yip@Chloes-MacBook-Pro.local>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
https://redis.io/docs/latest/commands/rename/
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.