Java: Adding command LCS
(No IDX option)
#1558
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
This only covers the signature where LCS returns the LCS as a String and LCS length as a Long. Map return type with the IDX option is coming as a part II
MINMATCHLEN
does not seem to work:And as a reference valkey-io/valkey#420 discusses how
WITHMATCHLEN
andMINMATCHLEN
only works/makes sense with theIDX
option but is still allowed to be added whenIDX
isn't present.For now, this PR will only include the default behavior without optional keywords and the
LEN
option behavior, which is mutually exclusive withIDX
, without the MINMATCHLEN optionBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.