-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Full tests on macos #1788
Full tests on macos #1788
Conversation
ikolomi
commented
Jul 3, 2024
•
edited
Loading
edited
- Enabled all tests on macos latest with all engine versions.
- Changed pubsub tests to be run in separate task.
- Fixed uds message parsing in glide-core.
- Refactored pubsub tests
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
37d48b7
to
829502c
Compare
c777180
to
43b1fcc
Compare
.github/workflows/python.yml
Outdated
- name: Install dependencies | ||
working-directory: ./python | ||
run: | | ||
python -m pip install --upgrade pip | ||
pip install mypy-protobuf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't need this, you don't test mypy in this job
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
right, removed
…nged pubsub tests to be run in separate task. 3. Fixed uds message parsing in glide-core. 4. Refactored pubsub tests
c423b4e
to
3443307
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please cleanup the test file from all commented out lines and then i'll re-review
.github/workflows/python.yml
Outdated
run: | | ||
source .env/bin/activate | ||
cd python/tests/ | ||
pytest -c ../../pytest_pubsub.ini --asyncio-mode=auto test_pubsub.py::TestPubSub |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can remove the pytest_pubsub.ini file and just do here:
pytest --asyncio-mode=auto -k test_pubsub
without any changes to the pytest.ini file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
right, done
.github/workflows/python.yml
Outdated
run: | | ||
source .env/bin/activate | ||
cd python/tests/ | ||
pytest -c ../../pytest_pubsub.ini --asyncio-mode=auto test_pubsub.py::TestPubSub |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
glide-core/src/socket_listener.rs
Outdated
match self.rotating_buffer.get_requests() { | ||
Ok(requests) => { | ||
if !requests.is_empty() { | ||
// continue to read from socket |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the comment isn't in the right place, should be above 126
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
correct, fixed
python/python/tests/test_pubsub.py
Outdated
# if cluster_mode: | ||
# # Since all tests run on the same cluster, when closing the client, garbage collector can be called after another test will start running | ||
# # In cluster mode, we check how many subscriptions received the message | ||
# # So to avoid flakiness, we make sure to unsubscribe from the channels | ||
# await listening_client.custom_command(["SUNSUBSCRIBE", channel]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remoived
python/python/tests/test_pubsub.py
Outdated
|
||
# await cast(GlideClusterClient, publishing_client).publish( | ||
# message, channel, sharded=True | ||
# ) | ||
|
||
# await cast(GlideClusterClient, publishing_client).publish( | ||
# message2, channel, sharded=True | ||
# ) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed
python/python/tests/test_pubsub.py
Outdated
# if cluster_mode: | ||
# # Since all tests run on the same cluster, when closing the client, garbage collector can be called after another test will start running | ||
# # In cluster mode, we check how many subscriptions received the message | ||
# # So to avoid flakiness, we make sure to unsubscribe from the channels | ||
# await listening_client.custom_command(["SUNSUBSCRIBE", channel]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remvove
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed
python/python/tests/test_pubsub.py
Outdated
# Publish messages to each channel | ||
for channel, message in channels_and_messages.items(): | ||
# TODO: enable when client closing works |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed
python/python/tests/test_pubsub.py
Outdated
# await cast(GlideClusterClient, publishing_client).publish( | ||
# message, channel, sharded=True | ||
# ) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed
0a1c115
to
e148bc5
Compare
@barshaul code cleaned up |
b8b5613
to
97ec251
Compare
1fb8ff4
to
019edc8
Compare
python/python/tests/test_pubsub.py
Outdated
# Publish messages to each channel | ||
for channel, message in channels_and_messages.items(): | ||
result = await publishing_client.publish(message, channel) | ||
# TODO: enable when client closing works |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some leftovers, other than that LGTM
65544cd
to
b435c50
Compare