Full tests on macos #1788
Merged
Full tests on macos #1788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ikolomi
commented
Jul 3, 2024
•
ikolomi
commented
- Enabled all tests on macos latest with all engine versions.
- Changed pubsub tests to be run in separate task.
- Fixed uds message parsing in glide-core.
- Refactored pubsub tests
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
ikolomi
force-pushed
the
full_tests_on_macos_rebased
branch
9 times, most recently
from
37d48b7
to
829502c
Compare
ikolomi
force-pushed
the
full_tests_on_macos_rebased
branch
2 times, most recently
from
c777180
to
43b1fcc
Compare
barshaul
reviewed
Jul 8, 2024
.github/workflows/python.yml
Outdated
Comment on lines
156
to
160
| - name: Install dependencies | ||
| working-directory: ./python | ||
| run: | | ||
| python -m pip install --upgrade pip | ||
| pip install mypy-protobuf |
There was a problem hiding this comment.
You don't need this, you don't test mypy in this job
…nged pubsub tests to be run in separate task. 3. Fixed uds message parsing in glide-core. 4. Refactored pubsub tests
ikolomi
force-pushed
the
full_tests_on_macos_rebased
branch
from
c423b4e
to
3443307
Compare
barshaul
requested changes
Jul 8, 2024
.github/workflows/python.yml
Outdated
| run: | | ||
| source .env/bin/activate | ||
| cd python/tests/ | ||
| pytest -c ../../pytest_pubsub.ini --asyncio-mode=auto test_pubsub.py::TestPubSub |
There was a problem hiding this comment.
You can remove the pytest_pubsub.ini file and just do here:
pytest --asyncio-mode=auto -k test_pubsub
without any changes to the pytest.ini file
.github/workflows/python.yml
Outdated
| run: | | ||
| source .env/bin/activate | ||
| cd python/tests/ | ||
| pytest -c ../../pytest_pubsub.ini --asyncio-mode=auto test_pubsub.py::TestPubSub |
glide-core/src/socket_listener.rs
Outdated
| match self.rotating_buffer.get_requests() { | ||
| Ok(requests) => { | ||
| if !requests.is_empty() { | ||
| // continue to read from socket |
There was a problem hiding this comment.
the comment isn't in the right place, should be above 126
python/python/tests/test_pubsub.py
Outdated
Comment on lines
604
to
608
| # if cluster_mode: | ||
| # # Since all tests run on the same cluster, when closing the client, garbage collector can be called after another test will start running | ||
| # # In cluster mode, we check how many subscriptions received the message | ||
| # # So to avoid flakiness, we make sure to unsubscribe from the channels | ||
| # await listening_client.custom_command(["SUNSUBSCRIBE", channel]) |
python/python/tests/test_pubsub.py
Outdated
Comment on lines
663
to
671
|
|
||
| # await cast(GlideClusterClient, publishing_client).publish( | ||
| # message, channel, sharded=True | ||
| # ) | ||
|
|
||
| # await cast(GlideClusterClient, publishing_client).publish( | ||
| # message2, channel, sharded=True | ||
| # ) | ||
|
|
python/python/tests/test_pubsub.py
Outdated
Comment on lines
697
to
701
| # if cluster_mode: | ||
| # # Since all tests run on the same cluster, when closing the client, garbage collector can be called after another test will start running | ||
| # # In cluster mode, we check how many subscriptions received the message | ||
| # # So to avoid flakiness, we make sure to unsubscribe from the channels | ||
| # await listening_client.custom_command(["SUNSUBSCRIBE", channel]) |
python/python/tests/test_pubsub.py
Outdated
| # Publish messages to each channel | ||
| for channel, message in channels_and_messages.items(): | ||
| # TODO: enable when client closing works |
python/python/tests/test_pubsub.py
Outdated
Comment on lines
772
to
775
| # await cast(GlideClusterClient, publishing_client).publish( | ||
| # message, channel, sharded=True | ||
| # ) | ||
|
|
ikolomi
force-pushed
the
full_tests_on_macos_rebased
branch
from
0a1c115
to
e148bc5
Compare
|
@barshaul code cleaned up |
ikolomi
force-pushed
the
full_tests_on_macos_rebased
branch
from
b8b5613
to
97ec251
Compare
ikolomi
force-pushed
the
full_tests_on_macos_rebased
branch
from
1fb8ff4
to
019edc8
Compare
barshaul
reviewed
Jul 8, 2024
python/python/tests/test_pubsub.py
Outdated
| # Publish messages to each channel | ||
| for channel, message in channels_and_messages.items(): | ||
| result = await publishing_client.publish(message, channel) | ||
| # TODO: enable when client closing works |
barshaul
approved these changes
Jul 8, 2024
ikolomi
force-pushed
the
full_tests_on_macos_rebased
branch
from
65544cd
to
b435c50
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.