Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node: add LPOS command #1927

Merged
merged 7 commits into from
Jul 18, 2024
Merged

Node: add LPOS command #1927

merged 7 commits into from
Jul 18, 2024

Conversation

GumpacG
Copy link
Collaborator

@GumpacG GumpacG commented Jul 12, 2024

@GumpacG GumpacG requested a review from a team as a code owner July 12, 2024 00:02
aaron-congo
aaron-congo reviewed Jul 12, 2024
View reviewed changes
node/src/BaseClient.ts Show resolved Hide resolved
node/src/BaseClient.ts Outdated Show resolved Hide resolved
node/src/BaseClient.ts Outdated Show resolved Hide resolved
node/src/BaseClient.ts Outdated Show resolved Hide resolved
node/src/Commands.ts Outdated Show resolved Hide resolved
node/tests/TestUtilities.ts Outdated Show resolved Hide resolved
node/tests/TestUtilities.ts Outdated Show resolved Hide resolved
Yury-Fridlyand
Yury-Fridlyand reviewed Jul 12, 2024
View reviewed changes
Copy link
Collaborator

@Yury-Fridlyand Yury-Fridlyand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, add changelog entry

node/src/Commands.ts Outdated Show resolved Hide resolved
@yipin-chen
Copy link
Collaborator

Please run the following commands to fix lint issues:
npm run lint
npm run prettier:format

aaron-congo
aaron-congo reviewed Jul 16, 2024
View reviewed changes
node/src/BaseClient.ts Outdated Show resolved Hide resolved
node/src/BaseClient.ts Outdated Show resolved Hide resolved
aaron-congo
aaron-congo reviewed Jul 16, 2024
View reviewed changes
node/src/Commands.ts Outdated Show resolved Hide resolved
@GumpacG GumpacG force-pushed the node/dev_guiang_lpos branch 2 times, most recently from 206b1ce to aedf324 Compare July 17, 2024 22:35
tjzhang-BQ
tjzhang-BQ approved these changes Jul 17, 2024
View reviewed changes
Copy link
Collaborator

@tjzhang-BQ tjzhang-BQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

aaron-congo
aaron-congo reviewed Jul 17, 2024
View reviewed changes
node/src/BaseClient.ts Outdated Show resolved Hide resolved
node/src/Transaction.ts Outdated Show resolved Hide resolved
node/src/BaseClient.ts Outdated Show resolved Hide resolved
node/src/command-options/LPosOptions.ts Outdated Show resolved Hide resolved
node/tests/TestUtilities.ts Outdated Show resolved Hide resolved
@GumpacG
Added lpos
5b510cc 
Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
@GumpacG
Addressed PR comments
3f4d4a2 
Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
@GumpacG
Reverted some changes
d1e3a78 
Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
@GumpacG
Refactored and addressed PR comments
d1e3e5b 
Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
@GumpacG
Rebased and resolved conflicts
9db6bab 
Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
@GumpacG
Addressed PR comments
ed553e4 
Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
@GumpacG
Rebased and resolved conflicts
b7b9ca8 
Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
@GumpacG GumpacG merged commit ebb04c1 into valkey-io:main Jul 18, 2024
8 checks passed
@GumpacG GumpacG deleted the node/dev_guiang_lpos branch July 18, 2024 01:33
cyip10 pushed a commit to Bit-Quill/valkey-glide that referenced this pull request Jul 18, 2024
@GumpacG @cyip10
Node: add LPOS command (valkey-io#1927)
10a2c93 
* Added LPOS node command

---------

Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
Signed-off-by: Chloe Yip <chloe.yip@improving.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaron-congo aaron-congo aaron-congo approved these changes

@Yury-Fridlyand Yury-Fridlyand Yury-Fridlyand approved these changes

@tjzhang-BQ tjzhang-BQ tjzhang-BQ approved these changes

Assignees
No one assigned
Labels
node
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@GumpacG @yipin-chen @aaron-congo @Yury-Fridlyand @tjzhang-BQ @jonathanl-bq