-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Node: added ZMPOP command #1994
Node: added ZMPOP command #1994
Conversation
a1a3d31
to
d049f60
Compare
* Mandatory option for zmpop. | ||
* Defines which elements to pop from the sorted set. | ||
*/ | ||
export enum ScoreFilter { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we put it into src/commands
dir?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add the two necessary occurrences for ScoreFilter in npm/glide/index.ts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we put it into src/commands dir?
This has yet to be discussed if we separate enums and option types in to separate files.
* Mandatory option for zmpop. | ||
* Defines which elements to pop from the sorted set. | ||
*/ | ||
export enum ScoreFilter { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add the two necessary occurrences for ScoreFilter in npm/glide/index.ts?
Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
6fd4c03
to
4b62e85
Compare
Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
https://valkey.io/commands/zmpop/