Node: added ZMPOP command #1994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GumpacG
force-pushed
the
node/integ_guiang_zmpop
branch
from
a1a3d31
to
d049f60
Compare
Yury-Fridlyand
approved these changes
Jul 22, 2024
| * Mandatory option for zmpop. | ||
| * Defines which elements to pop from the sorted set. | ||
| */ | ||
| export enum ScoreFilter { |
There was a problem hiding this comment.
Should we put it into src/commands dir?
There was a problem hiding this comment.
Can you add the two necessary occurrences for ScoreFilter in npm/glide/index.ts?
There was a problem hiding this comment.
Should we put it into src/commands dir?
This has yet to be discussed if we separate enums and option types in to separate files.
yipin-chen
approved these changes
Jul 22, 2024
aaron-congo
reviewed
Jul 22, 2024
| * Mandatory option for zmpop. | ||
| * Defines which elements to pop from the sorted set. | ||
| */ | ||
| export enum ScoreFilter { |
There was a problem hiding this comment.
Can you add the two necessary occurrences for ScoreFilter in npm/glide/index.ts?
Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
GumpacG
force-pushed
the
node/integ_guiang_zmpop
branch
from
6fd4c03
to
4b62e85
Compare
Yury-Fridlyand
approved these changes
Jul 22, 2024
aaron-congo
approved these changes
Jul 23, 2024
Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://valkey.io/commands/zmpop/