Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node: added WATCH and UNWATCH commands #2076

Merged
merged 10 commits into from
Aug 2, 2024
Merged

Node: added WATCH and UNWATCH commands #2076

merged 10 commits into from
Aug 2, 2024

Conversation

yipin-chen
Copy link
Collaborator

@yipin-chen
Node: added WATCH and UNWATCH commands
080df3c 
Signed-off-by: Yi-Pin Chen <yi-pin.chen@improving.com>
@yipin-chen yipin-chen added the node label Aug 1, 2024
@yipin-chen
Updated CHANGELOG
2df9df4 
Signed-off-by: Yi-Pin Chen <yi-pin.chen@improving.com>
@yipin-chen
Merge branch 'main' into node/integ_yipin_watch_unwatch_valkey-26
d46dac2
@yipin-chen
Fixed merge issues
2471c72 
Signed-off-by: Yi-Pin Chen <yi-pin.chen@improving.com>
@yipin-chen
Added async
97da612 
Signed-off-by: Yi-Pin Chen <yi-pin.chen@improving.com>
@yipin-chen
Added async
a7adc0b 
Signed-off-by: Yi-Pin Chen <yi-pin.chen@improving.com>
@yipin-chen yipin-chen marked this pull request as ready for review August 1, 2024 22:04
@yipin-chen yipin-chen requested a review from a team as a code owner August 1, 2024 22:04
acarbonetto
acarbonetto reviewed Aug 1, 2024
View reviewed changes
Copy link
Collaborator

@acarbonetto acarbonetto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also update existing tests for WATCH/UNWATCH:

acarbonetto
acarbonetto approved these changes Aug 1, 2024
View reviewed changes
node/src/BaseClient.ts Show resolved Hide resolved
node/src/BaseClient.ts Outdated Show resolved Hide resolved
node/tests/GlideClient.test.ts Show resolved Hide resolved
@yipin-chen yipin-chen requested a review from GumpacG August 2, 2024 00:29
@yipin-chen
Addressed review comments
1159c7b 
Signed-off-by: Yi-Pin Chen <yi-pin.chen@improving.com>
Yury-Fridlyand
Yury-Fridlyand reviewed Aug 2, 2024
View reviewed changes
node/src/BaseClient.ts Outdated Show resolved Hide resolved
node/src/BaseClient.ts Outdated Show resolved Hide resolved
node/src/BaseClient.ts Outdated Show resolved Hide resolved
node/src/GlideClient.ts Show resolved Hide resolved
node/src/GlideClient.ts Outdated Show resolved Hide resolved
node/src/GlideClusterClient.ts Outdated Show resolved Hide resolved
node/tests/GlideClusterClient.test.ts Show resolved Hide resolved
@yipin-chen
Addressed review comments
13cf882 
Signed-off-by: Yi-Pin Chen <yi-pin.chen@improving.com>
@yipin-chen
Modified reference link
4cb87db 
Signed-off-by: Yi-Pin Chen <yi-pin.chen@improving.com>
Yury-Fridlyand
Yury-Fridlyand approved these changes Aug 2, 2024
View reviewed changes
node/src/BaseClient.ts Outdated Show resolved Hide resolved
node/src/BaseClient.ts Outdated Show resolved Hide resolved
node/src/BaseClient.ts Outdated Show resolved Hide resolved
@yipin-chen
Updated examples
075862d 
Signed-off-by: Yi-Pin Chen <yi-pin.chen@improving.com>
@yipin-chen yipin-chen merged commit 14ebf28 into valkey-io:main Aug 2, 2024
8 checks passed
@yipin-chen yipin-chen deleted the node/integ_yipin_watch_unwatch_valkey-26 branch August 2, 2024 21:37
GumpacG pushed a commit to Bit-Quill/valkey-glide that referenced this pull request Aug 7, 2024
@yipin-chen @GumpacG
Node: added WATCH and UNWATCH commands (valkey-io#2076)
b1caf58 
* Node: added WATCH and UNWATCH commands

Signed-off-by: Yi-Pin Chen <yi-pin.chen@improving.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yury-Fridlyand Yury-Fridlyand Yury-Fridlyand approved these changes

@acarbonetto acarbonetto acarbonetto approved these changes

@GumpacG GumpacG Awaiting requested review from GumpacG

Assignees
No one assigned
Labels
node
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yipin-chen @GumpacG @Yury-Fridlyand @acarbonetto