-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Node: added WATCH and UNWATCH commands #2076
Merged
yipin-chen
merged 10 commits into
valkey-io:main
from
Bit-Quill:node/integ_yipin_watch_unwatch_valkey-26
Aug 2, 2024
Merged
Node: added WATCH and UNWATCH commands #2076
yipin-chen
merged 10 commits into
valkey-io:main
from
Bit-Quill:node/integ_yipin_watch_unwatch_valkey-26
Aug 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yi-Pin Chen <yi-pin.chen@improving.com>
Signed-off-by: Yi-Pin Chen <yi-pin.chen@improving.com>
Signed-off-by: Yi-Pin Chen <yi-pin.chen@improving.com>
Signed-off-by: Yi-Pin Chen <yi-pin.chen@improving.com>
Signed-off-by: Yi-Pin Chen <yi-pin.chen@improving.com>
acarbonetto
reviewed
Aug 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also update existing tests for WATCH/UNWATCH:
acarbonetto
approved these changes
Aug 1, 2024
Signed-off-by: Yi-Pin Chen <yi-pin.chen@improving.com>
Signed-off-by: Yi-Pin Chen <yi-pin.chen@improving.com>
Signed-off-by: Yi-Pin Chen <yi-pin.chen@improving.com>
Yury-Fridlyand
approved these changes
Aug 2, 2024
Signed-off-by: Yi-Pin Chen <yi-pin.chen@improving.com>
GumpacG
pushed a commit
to Bit-Quill/valkey-glide
that referenced
this pull request
Aug 7, 2024
* Node: added WATCH and UNWATCH commands Signed-off-by: Yi-Pin Chen <yi-pin.chen@improving.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://valkey.io/commands/watch/
https://valkey.io/commands/unwatch/